• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

alphagov / notifications-admin / 3073
85%
master: 94%

Build:
Build:
LAST BUILD BRANCH: fix-days-provider-history
DEFAULT BRANCH: master
Ran 16 May 2016 08:19AM UTC
Jobs 1
Files 53
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
3073

push

travis-ci

quis
Handle files that can’t be interpreted as spreadsheets

There shouldn’t be a case where we see a `ValueError` on upload any
more. Our file handling should be robust enough to deal with whatever is
thrown at it.

This commit:
- adds test files with bad data (PNG files with their extensions changed to look
  like spreadsheets)
- catches whatever exceptions are raised by trying to parse these files
- returns a helpful flash message to the user

Anything else should raise a `500`, eg if the file can’t be uploaded to S3.

4 of 4 new or added lines in 1 file covered. (100.0%)

1778 of 2086 relevant lines covered (85.23%)

0.85 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
5
100.0
app/main/views/send.py
10
100.0
app/main/uploader.py
Jobs
ID Job ID Ran Files Coverage
1 3073.1 (auth_token=[secure]) 16 May 2016 08:19AM UTC 0
85.23
Travis Job 3073.1
Source Files on build 3073
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #3073
  • 7bbc307a on github
  • Prev Build on accept-common-spreadsheet-formats (#3072)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc