alphagov / notifications-admin / 3073

85%

master: 94%

push

travis-ci

Handle files that can’t be interpreted as spreadsheets

There shouldn’t be a case where we see a `ValueError` on upload any
more. Our file handling should be robust enough to deal with whatever is
thrown at it.

This commit:
- adds test files with bad data (PNG files with their extensions changed to look
  like spreadsheets)
- catches whatever exceptions are raised by trying to parse these files
- returns a helpful flash message to the user

Anything else should raise a `500`, eg if the file can’t be uploaded to S3.

4 of 4 new or added lines in 1 file covered. (100.0%)

1778 of 2086 relevant lines covered (85.23%)

0.85 hits per line