rust-bitcoin / rust-bitcoin / 9272989467 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#2585: Improve array macros

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/6ba7758b30c91bbe0caebd5b373839739e51bf3e">6ba7758b3 Improve array macros (Tobin C. Harding)

Pull request description:

  Currently we have two macros used when creating array wrapper types, one is in `internals` and the other in `bitcoin::internal_macros`. It is not immediately obvious what is what and why there are two.

  Improve the macros by:

  - Move the inherent functions to `impl_array_newtype`
  - Use `*_byte_array` for the names instead of `*_bytes`
  - Re-name the other macro to match what it now does

ACKs for top commit:
  apoelstra:
    ACK 6ba7758b30c91bbe0caebd5b373839739e51bf3e

Tree-SHA512: 36ed0fae0f4ff41fd8660923ffdfc74af2a

19324 of 23203 relevant lines covered (83.28%)

16624.24 hits per line