rust-bitcoin / rust-bitcoin / 9272440399 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#2755: Fix units public re-exports

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d2a597c90ddb8eec06d660640e332460884a87e1">d2a597c90<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d06a32d9ca18969434f7a1d48cc3742ed09f752"> unit: Group re-exports (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d242125ae4ae2f33575236166e137ce3b5d657e7">d242125ae</a> units: Fix error re-exports (Tobin C. Harding)

Pull request description:

  First patch is the meat and potatoes, second one is just a trivial refactor to the same code, done separately so as to make the changes in the first patch more clear.

  From patch 1
  ```
      units: Fix error re-exports

      Currently we re-export two error types at the crate root, this is
      surprising because:

      - Why not none or all the rest?
      - Why these two?

      Observe that the `ParseIntError` is special in that it is used by
      other modules so its good to have at the crate root (other errors are
      expected to be used with a module prefix eg, `amount::ParseError`).

      There is no obvious reason why `ParseAmountError` is re-exported.

      Comment and doc inline the `ParesIntError`, remove the re-export of
      the `ParseAmountError`.
  ```

ACKs for top commit:
  apoelstra:
    ACK d2a597c90ddb8eec06d660640e332460884a87e1

Tree-SHA512: 38d3f59036ea99cb3422f7899cba1abf762

19324 of 23201 relevant lines covered (83.29%)

16694.09 hits per line