1
64%
master: 64%

Ran 11 Apr 2024 09:02PM UTC

Files 144

Run time 7s

Badge

Embed ▾

Committed 11 Apr 2024 08:48PM UTC coverage: 64.673% (-0.02%) from 64.688%

Job # 8653071263.1

Build Type

push

github

Committed by

pcolberg

Commit Message

spdlog: do not drop logger in destructor

For static objects, the order of destruction is in reverse of the order
of construction, but the latter is hard to control except among static
objects defined within the same translation unit. This means that spdlog
may be destructed before spdlog::drop() is invoked in the destructor,
which leads to a segmentation fault due to memory use-after-free.

Move call of spdlog::drop() from destructor to main() function, to
ensure the logger may be re-registered with the same name in tests.
Use Scope Guard pattern to implement RAII for logger registration.

Link: https://github.com/ros2/rclcpp/issues/933
Link: https://github.com/gabime/spdlog/issues/1738
Link: https://github.com/gabime/spdlog/issues/2113
Link: https://en.wikibooks.org/wiki/More_C++_Idioms/Scope_Guard
Closes: https://hsdes.intel.com/appstore/article/#/22019839238
Signed-off-by: Peter Colberg <peter.colberg@intel.com>

Run Details

15823 of 24466 relevant lines covered (64.67%)

8958.79 hits per line

OFS / opae-sdk / 8653071263 / 1
64%
master: 64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8653071263.1

OFS / opae-sdk / 8653071263 / 1 64% master: 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8653071263.1

OFS / opae-sdk / 8653071263 / 1
64%
master: 64%

README BADGES
x