OFS / opae-sdk / 8653071263

64%

push

github

spdlog: do not drop logger in destructor

For static objects, the order of destruction is in reverse of the order
of construction, but the latter is hard to control except among static
objects defined within the same translation unit. This means that spdlog
may be destructed before spdlog::drop() is invoked in the destructor,
which leads to a segmentation fault due to memory use-after-free.

Move call of spdlog::drop() from destructor to main() function, to
ensure the logger may be re-registered with the same name in tests.
Use Scope Guard pattern to implement RAII for logger registration.

Link: https://github.com/ros2/rclcpp/issues/933
Link: https://github.com/gabime/spdlog/issues/1738
Link: https://github.com/gabime/spdlog/issues/2113
Link: https://en.wikibooks.org/wiki/More_C++_Idioms/Scope_Guard
Closes: https://hsdes.intel.com/appstore/article/#/22019839238
Signed-off-by: Peter Colberg <peter.colberg@intel.com>

6 of 18 new or added lines in 3 files covered. (33.33%)

15823 of 24466 relevant lines covered (64.67%)

8958.79 hits per line