31
95%
main: 95%

Ran 02 Apr 2024 04:32PM UTC

Files 41

Run time 2s

Badge

Embed ▾

Committed 02 Apr 2024 04:05PM UTC coverage: 90.415% (-0.02%) from 90.434%

Job # 8525929178.31

Build Type

push

github

Committed by

thibaultcha

Commit Message

fix(ffi) allow 'load()' to fail and be invoked again

Before instantiating filter chains and request contexts, filters
themselves (i.e. their root context) are represented in the module.
Eventually, `ngx_proxy_wasm_start` iterates over all filters to start
their root contexts.

Previously, all filters declared in `proxy_wasm` directives were stored
globally. With the introduction of the FFI filters can be dynamically
added to the internal representation during `proxy_wasm.load`, which
makes it possible for `ngx_proxy_wasm_start` to be invoked several
times.

However, since the filters structure was global then all previously
declared filters were started again, including filters that previously
failed initializing their root contexts. This was not happening with
`proxy_wasm` directives since a filter failing initialization in that
case would not allow Nginx to start in the first place.

Now all filters are stored in a "filters root" structure which can
divide filter root contexts as needed. Each worker has a global "worker
filters root", and each `ngx_wasm_ops_plan` created by the FFI has its
own isolated "filters root".

Co-Authored-By: Michael Martin <michael.martin@konghq.com>

Run Details

6980 of 7720 relevant lines covered (90.41%)

4416.65 hits per line

Kong / ngx_wasm_module / 8525929178 / 31
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8525929178.31

Kong / ngx_wasm_module / 8525929178 / 31 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8525929178.31

Kong / ngx_wasm_module / 8525929178 / 31
95%
main: 95%

README BADGES
x