8525929178
95%

Ran 02 Apr 2024 04:21PM UTC

Jobs 40

Files 47

Run time 1min

Badge

Embed ▾

Committed 02 Apr 2024 04:05PM UTC coverage: 93.124% (+2.1%) from 91.059%

Build # 8525929178

Build Type

push

github

Committed by

thibaultcha

Commit Message

fix(ffi) allow 'load()' to fail and be invoked again

Before instantiating filter chains and request contexts, filters
themselves (i.e. their root context) are represented in the module.
Eventually, `ngx_proxy_wasm_start` iterates over all filters to start
their root contexts.

Previously, all filters declared in `proxy_wasm` directives were stored
globally. With the introduction of the FFI filters can be dynamically
added to the internal representation during `proxy_wasm.load`, which
makes it possible for `ngx_proxy_wasm_start` to be invoked several
times.

However, since the filters structure was global then all previously
declared filters were started again, including filters that previously
failed initializing their root contexts. This was not happening with
`proxy_wasm` directives since a filter failing initialization in that
case would not allow Nginx to start in the first place.

Now all filters are stored in a "filters root" structure which can
divide filter root contexts as needed. Each worker has a global "worker
filters root", and each `ngx_wasm_ops_plan` created by the FFI has its
own isolated "filters root".

Co-Authored-By: Michael Martin <michael.martin@konghq.com>

Run Details

8966 of 9628 relevant lines covered (93.12%)

120066.8 hits per line

Jobs

ID	Job ID	Ran	Coverage
31	unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8525929178.31	02 Apr 2024 04:25PM UTC	90.41	GitHub Action Run
32	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic - 8525929178.32	02 Apr 2024 04:30PM UTC	90.6	GitHub Action Run
33	unit-ngx_1.25.4-wasmer-no_ipc-no_ssl-no_debug-no_hup-static - 8525929178.33	02 Apr 2024 04:21PM UTC	88.56	GitHub Action Run
34	unit-ngx_1.25.4-wasmer-no_ipc-ssl-no_debug-no_hup-static - 8525929178.34	02 Apr 2024 04:21PM UTC	88.92	GitHub Action Run
35	unit-ngx_1.25.4-v8-no_ipc-ssl-debug-no_hup-static - 8525929178.35	02 Apr 2024 04:26PM UTC	90.77	GitHub Action Run
36	unit-ngx_1.25.4-wasmtime-ipc-no_ssl-debug-no_hup-static - 8525929178.36	02 Apr 2024 04:23PM UTC	90.0	GitHub Action Run
37	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-dynamic - 8525929178.37	02 Apr 2024 04:31PM UTC	89.48	GitHub Action Run
38	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-static - 8525929178.38	02 Apr 2024 04:30PM UTC	90.58	GitHub Action Run
39	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-static - 8525929178.39	02 Apr 2024 04:31PM UTC	89.47	GitHub Action Run
40	unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static - 8525929178.40	02 Apr 2024 04:23PM UTC	90.36	GitHub Action Run
29	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic - 8525810201.29	02 Apr 2024 04:24PM UTC	90.58	GitHub Action Run
23	unit-ngx_1.25.4-wasmer-no_ipc-ssl-no_debug-no_hup-static - 8525810201.23	02 Apr 2024 04:13PM UTC	88.94	GitHub Action Run
26	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-static - 8525810201.26	02 Apr 2024 04:22PM UTC	89.48	GitHub Action Run
5	unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8439118370.5	26 Mar 2024 04:20PM UTC	90.45	GitHub Action Run
2	unit-ngx_1.25.4-wasmer-no_ipc-no_ssl-no_debug-no_hup-static - 8439118370.2	26 Mar 2024 04:18PM UTC	88.59	GitHub Action Run
6	unit-ngx_1.25.4-v8-no_ipc-ssl-debug-no_hup-static - 8439118370.6	26 Mar 2024 04:22PM UTC	90.8	GitHub Action Run
9	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-static - 8439118370.9	26 Mar 2024 04:28PM UTC	89.49	GitHub Action Run
7	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic - 8439118370.7	26 Mar 2024 04:26PM UTC	90.59	GitHub Action Run
13	unit-ngx_1.25.4-wasmtime-ipc-no_ssl-debug-no_hup-static - 8447245783.13	27 Mar 2024 05:59AM UTC	90.02	GitHub Action Run
14	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-static - 8447245783.14	27 Mar 2024 06:07AM UTC	89.48	GitHub Action Run
12	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic - 8447245783.12	27 Mar 2024 06:05AM UTC	90.58	GitHub Action Run
15	unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8447245783.15	27 Mar 2024 05:59AM UTC	90.43	GitHub Action Run
17	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-dynamic - 8447245783.17	27 Mar 2024 06:06AM UTC	89.5	GitHub Action Run
20	unit-ngx_1.25.4-v8-no_ipc-ssl-debug-no_hup-static - 8447245783.20	27 Mar 2024 06:00AM UTC	90.79	GitHub Action Run
28	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-static - 8525810201.28	02 Apr 2024 04:21PM UTC	90.56	GitHub Action Run
16	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-static - 8447245783.16	27 Mar 2024 06:05AM UTC	90.54	GitHub Action Run
18	unit-ngx_1.25.4-wasmer-no_ipc-ssl-no_debug-no_hup-static - 8447245783.18	27 Mar 2024 05:57AM UTC	88.92	GitHub Action Run
11	unit-ngx_1.25.4-wasmer-no_ipc-no_ssl-no_debug-no_hup-static - 8447245783.11	27 Mar 2024 05:57AM UTC	88.58	GitHub Action Run
8	unit-openresty_1.25.3.1-wasmtime-no_ipc-ssl-debug-no_hup-static - 8439118370.8	26 Mar 2024 04:26PM UTC	90.57	GitHub Action Run
3	unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static - 8439118370.3	26 Mar 2024 04:20PM UTC	90.4	GitHub Action Run
1	unit-ngx_1.25.4-wasmer-no_ipc-ssl-no_debug-no_hup-static - 8439118370.1	26 Mar 2024 04:18PM UTC	88.95	GitHub Action Run
4	unit-ngx_1.25.4-wasmtime-ipc-no_ssl-debug-no_hup-static - 8439118370.4	26 Mar 2024 04:21PM UTC	90.03	GitHub Action Run
10	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-dynamic - 8439118370.10	26 Mar 2024 04:57PM UTC	89.51	GitHub Action Run
24	unit-ngx_1.25.4-wasmer-no_ipc-no_ssl-no_debug-no_hup-static - 8525810201.24	02 Apr 2024 04:12PM UTC	88.58	GitHub Action Run
30	unit-ngx_1.25.4-wasmtime-no_ipc-ssl-debug-hup-dynamic - 8525810201.30	02 Apr 2024 04:25PM UTC	89.51	GitHub Action Run
27	unit-ngx_1.25.4-v8-no_ipc-ssl-debug-no_hup-static - 8525810201.27	02 Apr 2024 04:16PM UTC	90.79	GitHub Action Run
22	unit-ngx_1.25.4-wasmtime-ipc-no_ssl-debug-no_hup-static - 8525810201.22	02 Apr 2024 04:16PM UTC	90.02	GitHub Action Run
21	unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static - 8525810201.21	02 Apr 2024 04:15PM UTC	90.38	GitHub Action Run
25	unit-ngx_1.25.4-wasmer-no_ipc-ssl-debug-no_hup-static - 8525810201.25	02 Apr 2024 04:15PM UTC	90.43	GitHub Action Run
19	unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static - 8447245783.19	27 Mar 2024 05:59AM UTC	90.38	GitHub Action Run

Source Files on build 8525929178

Detailed source file information is not available for this build.

Kong / ngx_wasm_module / 8525929178
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8525929178

Kong / ngx_wasm_module / 8525929178 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8525929178

Kong / ngx_wasm_module / 8525929178
95%

README BADGES
x