1
72%
master: 72%

Ran 29 Mar 2024 10:35PM UTC

Files 673

Run time 13s

Badge

Embed ▾

Committed 29 Mar 2024 10:13PM UTC coverage: 65.249% (-0.01%) from 65.259%

Job # 018e8c46-474f-4f6b-80ab-751d576edd29.1

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Deadlock fix in acquireShards (#5825)

Fixing the deadlock demonstrated in #5824.

I decided to move the channel-writing entirely before consuming so it's a bit more accidental-change-resistant: some kinds of simple incorrect changes will lead to an _immediate_ deadlock every time, rather than a random chance of one.

And if someone _does_ want to move it after and go back to a smaller buffer, more code will have to be changed, so hopefully people will pay more attention to the concurrency risks involved.

More generally, the atomic shutdown stuff is _highly_ prone to causing this kind of error because there's no way to wait on it safely, and I would really love for us to get rid of it.

Run Details

95414 of 146231 relevant lines covered (65.25%)

2380.23 hits per line

uber / cadence / 018e8c46-474f-4f6b-80ab-751d576edd29 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018e8c46-474f-4f6b-80ab-751d576edd29.1

uber / cadence / 018e8c46-474f-4f6b-80ab-751d576edd29 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018e8c46-474f-4f6b-80ab-751d576edd29.1

uber / cadence / 018e8c46-474f-4f6b-80ab-751d576edd29 / 1
72%
master: 72%

README BADGES
x