• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / cadence / 018e8c46-474f-4f6b-80ab-751d576edd29
72%

Build:
DEFAULT BRANCH: master
Ran 29 Mar 2024 10:35PM UTC
Jobs 1
Files 673
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Mar 2024 10:13PM UTC coverage: 65.249% (-0.01%) from 65.259%
018e8c46-474f-4f6b-80ab-751d576edd29

push

buildkite

web-flow
Deadlock fix in acquireShards (#5825)

Fixing the deadlock demonstrated in #5824.

I decided to move the channel-writing entirely before consuming so it's a bit more accidental-change-resistant: some kinds of simple incorrect changes will lead to an _immediate_ deadlock every time, rather than a random chance of one.

And if someone _does_ want to move it after and go back to a smaller buffer, more code will have to be changed, so hopefully people will pay more attention to the concurrency risks involved.

More generally, the atomic shutdown stuff is _highly_ prone to causing this kind of error because there's no way to wait on it safely, and I would really love for us to get rid of it.

8 of 8 new or added lines in 1 file covered. (100.0%)

53 existing lines in 12 files now uncovered.

95414 of 146231 relevant lines covered (65.25%)

2380.23 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
89.05
0.5% common/task/weighted_round_robin_task_scheduler.go
2
87.01
0.0% service/history/task/transfer_standby_task_executor.go
2
84.54
2.06% common/task/fifo_task_scheduler.go
2
73.68
-2.11% common/persistence/sql/sqlplugin/mysql/task.go
2
73.23
-1.57% service/matching/db.go
2
90.72
-0.69% service/matching/matcher.go
2
79.49
-2.56% common/persistence/sql/sqlplugin/mysql/db.go
2
66.67
-0.5% common/persistence/historyManager.go
3
50.18
-0.55% common/log/tag/tags.go
5
84.08
-0.8% service/matching/taskReader.go
10
61.71
1.9% service/history/execution/mutable_state_task_refresher.go
20
70.57
-5.71% service/history/task/task_util.go
Jobs
ID Job ID Ran Files Coverage
1 018e8c46-474f-4f6b-80ab-751d576edd29.1 29 Mar 2024 10:35PM UTC 673
65.25
Source Files on build 018e8c46-474f-4f6b-80ab-751d576edd29
  • Tree
  • List 673
  • Changed 281
  • Source Changed 0
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 5003ffbf on github
  • Prev Build on master (#018E86DC...)
  • Next Build on master (#018E9B7B...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc