uber / cadence / 018e8c46-474f-4f6b-80ab-751d576edd29

72%

Build Type

push

buildkite

Committed by web-flow

Commit Message

Deadlock fix in acquireShards (#5825)

Fixing the deadlock demonstrated in #5824.

I decided to move the channel-writing entirely before consuming so it's a bit more accidental-change-resistant: some kinds of simple incorrect changes will lead to an _immediate_ deadlock every time, rather than a random chance of one.

And if someone _does_ want to move it after and go back to a smaller buffer, more code will have to be changed, so hopefully people will pay more attention to the concurrency risks involved.

More generally, the atomic shutdown stuff is _highly_ prone to causing this kind of error because there's no way to wait on it safely, and I would really love for us to get rid of it.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

53 existing lines in 12 files now uncovered.

95414 of 146231 relevant lines covered (65.25%)

2380.23 hits per line