1
72%
master: 72%

Ran 18 Mar 2024 10:51PM UTC

Files 670

Run time 20s

Badge

Embed ▾

Committed 18 Mar 2024 10:24PM UTC coverage: 64.926% (-0.005%) from 64.931%

Job # 018e53aa-bc8b-40e2-9d7c-012f8da56b45.1

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Fix checksum validation for SQL implementation (#5790)

What changed?
Add a check for the SQL implementation of GetWorkflowExecution operation to exclude false positive checksum validation failure cases.

Why?
To make sure the checksum validation result is true, the data we read from GetWorkflowExecution operation are from a consistent view. In the NoSQL implementation, the operation is a single read, so the data is from a consistent view. However, in the SQL implementation, the operation is multiple reads from different table. If there is a concurrent update, the data we read isn't from a consistent view and the checksum validation could fail. Normally, we don't have concurrent updates with reads. But when the shard ownership changed, it might not be the case.

Run Details

94774 of 145972 relevant lines covered (64.93%)

2395.07 hits per line

uber / cadence / 018e53aa-bc8b-40e2-9d7c-012f8da56b45 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018e53aa-bc8b-40e2-9d7c-012f8da56b45.1

uber / cadence / 018e53aa-bc8b-40e2-9d7c-012f8da56b45 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 018e53aa-bc8b-40e2-9d7c-012f8da56b45.1

uber / cadence / 018e53aa-bc8b-40e2-9d7c-012f8da56b45 / 1
72%
master: 72%

README BADGES
x