• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / cadence / 018e53aa-bc8b-40e2-9d7c-012f8da56b45
72%

Build:
DEFAULT BRANCH: master
Ran 18 Mar 2024 10:51PM UTC
Jobs 1
Files 670
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Mar 2024 10:24PM UTC coverage: 64.926% (-0.005%) from 64.931%
018e53aa-bc8b-40e2-9d7c-012f8da56b45

push

buildkite

web-flow
Fix checksum validation for SQL implementation (#5790)

What changed?
Add a check for the SQL implementation of GetWorkflowExecution operation to exclude false positive checksum validation failure cases.

Why?
To make sure the checksum validation result is true, the data we read from GetWorkflowExecution operation are from a consistent view. In the NoSQL implementation, the operation is a single read, so the data is from a consistent view. However, in the SQL implementation, the operation is multiple reads from different table. If there is a concurrent update, the data we read isn't from a consistent view and the checksum validation could fail. Normally, we don't have concurrent updates with reads. But when the shard ownership changed, it might not be the case.

24 of 26 new or added lines in 5 files covered. (92.31%)

66 existing lines in 14 files now uncovered.

94774 of 145972 relevant lines covered (64.93%)

2395.07 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
8.7
-0.01% common/persistence/persistence-tests/persistenceTestBase.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
88.56
-0.5% common/task/weighted_round_robin_task_scheduler.go
2
93.06
-1.39% common/task/parallel_task_processor.go
2
35.78
-0.28% client/history/client.go
2
49.59
-0.13% service/history/handler/handler.go
2
85.57
1.03% common/task/fifo_task_scheduler.go
2
90.72
-0.69% service/matching/matcher.go
3
84.82
-0.28% common/persistence/sql/sql_execution_store_util.go
3
86.6
1.55% service/history/task/fetcher.go
4
80.95
-2.12% common/archiver/filestore/historyArchiver.go
6
87.42
-0.41% service/history/task/transfer_standby_task_executor.go
6
62.05
-0.18% service/frontend/api/handler.go
9
68.3
-0.32% service/history/engine/engineimpl/historyEngine.go
9
62.02
-3.49% service/frontend/wrappers/metered/metered.go
14
64.87
-3.8% service/history/execution/mutable_state_task_refresher.go
Jobs
ID Job ID Ran Files Coverage
1 018e53aa-bc8b-40e2-9d7c-012f8da56b45.1 18 Mar 2024 10:51PM UTC 670
64.93
Source Files on build 018e53aa-bc8b-40e2-9d7c-012f8da56b45
  • Tree
  • List 670
  • Changed 277
  • Source Changed 0
  • Coverage Changed 31
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • d60041ff on github
  • Prev Build on master (#018E5375...)
  • Next Build on master (#018E54D9...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc