uber / cadence / 018e53aa-bc8b-40e2-9d7c-012f8da56b45

72%

Build Type

push

buildkite

Committed by web-flow

Commit Message

Fix checksum validation for SQL implementation (#5790)

What changed?
Add a check for the SQL implementation of GetWorkflowExecution operation to exclude false positive checksum validation failure cases.

Why?
To make sure the checksum validation result is true, the data we read from GetWorkflowExecution operation are from a consistent view. In the NoSQL implementation, the operation is a single read, so the data is from a consistent view. However, in the SQL implementation, the operation is multiple reads from different table. If there is a concurrent update, the data we read isn't from a consistent view and the checksum validation could fail. Normally, we don't have concurrent updates with reads. But when the shard ownership changed, it might not be the case.

Run Details

24 of 26 new or added lines in 5 files covered. (92.31%)

66 existing lines in 14 files now uncovered.

94774 of 145972 relevant lines covered (64.93%)

2395.07 hits per line