12
12%
master: %

Ran 08 Apr 2016 07:19PM UTC

Files 89

Run time 3s

Badge

Embed ▾

Committed 08 Apr 2016 06:46PM UTC coverage: 73.687%. First build

Job # GROUP=python

Build Type

push

travis-ci

Committed by

minrk

Commit Message

Backport PR #1325: Fix handling of preflight requests

Hi,

I believe I've found a bug in the way that OPTIONS requests are handled by the notebook server. Pre-flighted OPTIONS requests do not include authentication information, which means that we should not expect these to be authenticated and so should not be using the @web.authenticated decorator. Authentication will be validated when the real PUT/POST etc request is issued after the preflight.

FWIW this behaviour is documented by others in different contexts (see for example: http://giix.nl/2015/03/10/cross-origin-resource-sharing-cors-and-kerberos-webserver-auth/).
...

Coverage Stats

4730 of 6419 relevant lines covered (73.69%)

0.74 hits per line

jupyter / notebook / 2177 / 12
12%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2177.12 (GROUP=python)

jupyter / notebook / 2177 / 12 12% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2177.12 (GROUP=python)

jupyter / notebook / 2177 / 12
12%
master: %

README BADGES
x