2177
12%
master: %

Ran 08 Apr 2016 07:08PM UTC

Jobs 9

Files 89

Run time 10min

Badge

Embed ▾

pending completion

Build # 2177

Build Type

push

travis-ci

Committed by

minrk

Commit Message

Backport PR #1325: Fix handling of preflight requests

Hi,

I believe I've found a bug in the way that OPTIONS requests are handled by the notebook server. Pre-flighted OPTIONS requests do not include authentication information, which means that we should not expect these to be authenticated and so should not be using the @web.authenticated decorator. Authentication will be validated when the real PUT/POST etc request is issued after the preflight.

FWIW this behaviour is documented by others in different contexts (see for example: http://giix.nl/2015/03/10/cross-origin-resource-sharing-cors-and-kerberos-webserver-auth/).
...

Run Details

4750 of 6419 relevant lines covered (74.0%)

2.21 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2177.1 (GROUP=python)	08 Apr 2016 07:08PM UTC	73.69	Travis Job 2177.1
2	2177.2 (GROUP=js/base)	08 Apr 2016 07:10PM UTC		Travis Job 2177.2
3	2177.3 (GROUP=js/notebook)	08 Apr 2016 07:14PM UTC		Travis Job 2177.3
5	2177.5 (GROUP=js/tree)	08 Apr 2016 07:14PM UTC		Travis Job 2177.5
6	2177.6 (GROUP=python)	08 Apr 2016 07:16PM UTC	73.97	Travis Job 2177.6
7	2177.7 (GROUP=js/base)	08 Apr 2016 07:16PM UTC		Travis Job 2177.7
8	2177.8 (GROUP=js/notebook)	08 Apr 2016 07:19PM UTC		Travis Job 2177.8
10	2177.10 (GROUP=js/tree)	08 Apr 2016 07:17PM UTC		Travis Job 2177.10
12	2177.12 (GROUP=python)	08 Apr 2016 07:19PM UTC	73.69	Travis Job 2177.12

Source Files on build 2177

Detailed source file information is not available for this build.

jupyter / notebook / 2177
12%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2177

jupyter / notebook / 2177 12% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2177

jupyter / notebook / 2177
12%
master: %

README BADGES
x