2
0%
master: 0%

Ran 29 Dec 2023 03:12PM UTC

Files 117

Run time 2s

Badge

Embed ▾

Committed 29 Dec 2023 03:10PM UTC coverage: 75.892% (+0.006%) from 75.886%

Job # 7357739561.2

Build Type

push

github

Committed by

web-flow

Commit Message

fix: avoid panic from tracing on bad request (#2871)

This fixes a panic which arises from the tracing components when a request has some defect which results in an error when creating the operation context. The transports consistently handle this by calling `DispatchError(graphql.WithOperationContext(ctx, rc), err)` where `rc` is the OperationContext which was not correctly constructed. This seems dangerous, because middleware may assume that if there in an `OperationContext` in the `context.Context` than they are being invoked on a normal codepath and can assume their other interceptors have been invoked in the normal order. Also, using a value returned by a function which also returned a non-nil error is very unusual. However, I have no idea what the impact of changing that dangerous behavior in the transports would be, so I opted to make the tracing component more resilient instead.

Run Details

6916 of 9113 relevant lines covered (75.89%)

718.33 hits per line

99designs / gqlgen / 7357739561 / 2
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7357739561.2

99designs / gqlgen / 7357739561 / 2 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7357739561.2

99designs / gqlgen / 7357739561 / 2
0%
master: 0%

README BADGES
x