99designs / gqlgen / 7357739561

60%

Build Type

push

github

Committed by web-flow

Commit Message

fix: avoid panic from tracing on bad request (#2871)

This fixes a panic which arises from the tracing components when a request has some defect which results in an error when creating the operation context. The transports consistently handle this by calling `DispatchError(graphql.WithOperationContext(ctx, rc), err)` where `rc` is the OperationContext which was not correctly constructed. This seems dangerous, because middleware may assume that if there in an `OperationContext` in the `context.Context` than they are being invoked on a normal codepath and can assume their other interceptors have been invoked in the normal order. Also, using a value returned by a function which also returned a non-nil error is very unusual. However, I have no idea what the impact of changing that dangerous behavior in the transports would be, so I opted to make the tracing component more resilient instead.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

7 existing lines in 3 files now uncovered.

6918 of 9113 relevant lines covered (75.91%)

1437.31 hits per line