1
78%
master: 79%

Ran 15 Dec 2023 07:22PM UTC

Files 257

Run time 7s

Badge

Embed ▾

Committed 15 Dec 2023 07:20PM UTC coverage: 63.093% (+0.003%) from 63.09%

Job # 7226187565.1

Build Type

push

github

Committed by

jrfnl

Commit Message

Replace default value of first parameter in getErrorList() with ''

Replacing the default value with an empty string. Per Juliette's comment
(https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/163#discussion_r1426775588)
there are three reasons why we want to do that:

- The default value has no value in practice. It is an optional argument which is not enforced via the abstract functions, but is passed in all cases, so the default is never used in practice.
- Setting the default value as file 1 also has an assumption implied, while IMO assumptions have no place in a test suite.
- Maintainability - one less thing to have to keep in sync and to guard against typos

Run Details

14837 of 23516 relevant lines covered (63.09%)

1.82 hits per line

PHPCSStandards / PHP_CodeSniffer / 7226187565 / 1
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.3-custom-ini-false - 7226187565.1

PHPCSStandards / PHP_CodeSniffer / 7226187565 / 1 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.3-custom-ini-false - 7226187565.1

PHPCSStandards / PHP_CodeSniffer / 7226187565 / 1
78%
master: 79%

README BADGES
x