7226187565
76%
master: 78%

Ran 15 Dec 2023 07:22PM UTC

Jobs 3

Files 257

Run time 24s

Badge

Embed ▾

Committed 15 Dec 2023 07:20PM UTC coverage: 63.966% (+0.003%) from 63.963%

Build # 7226187565

Build Type

push

github

Committed by

jrfnl

Commit Message

Replace default value of first parameter in getErrorList() with ''

Replacing the default value with an empty string. Per Juliette's comment
(https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/163#discussion_r1426775588)
there are three reasons why we want to do that:

- The default value has no value in practice. It is an optional argument which is not enforced via the abstract functions, but is passed in all cases, so the default is never used in practice.
- Setting the default value as file 1 also has an assumption implied, while IMO assumptions have no place in a test suite.
- Maintainability - one less thing to have to keep in sync and to guard against typos

Run Details

15112 of 23625 relevant lines covered (63.97%)

5.38 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	php-8.3-custom-ini-false - 7226187565.1	15 Dec 2023 07:22PM UTC	257	63.09	GitHub Action Run
2	php-8.0-custom-ini-true - 7226187565.2	15 Dec 2023 07:22PM UTC	257	63.05	GitHub Action Run
3	php-7.2-custom-ini-false - 7226187565.3	15 Dec 2023 07:22PM UTC	257	59.94	GitHub Action Run

PHPCSStandards / PHP_CodeSniffer / 7226187565
76%
master: 78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7226187565

PHPCSStandards / PHP_CodeSniffer / 7226187565 76% master: 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7226187565

PHPCSStandards / PHP_CodeSniffer / 7226187565
76%
master: 78%

README BADGES
x