2
85%
dev: 88%

Ran 04 Apr 2016 07:15PM UTC

Files 40

Run time 2s

Badge

Embed ▾

Committed 04 Apr 2016 07:04PM UTC coverage: 84.679%. First build

Job # 1489.2

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Remove error log if onClosedConnRemoved does not find peer

If some peer P has multiple connections C1 and C2, and both close
at the same time, then we have the following sequence of events.
Each connection is running on a separate goroutine.

C1 calls connectionCloseStateChange, removes itself from the connections
list, and is scheduled out before onClosedConnRemoved

C2 calls connectionCloseStateChange, removes itself from the list
and runs onClosedConnRemoved, which will see that there's no connection
for this peer, and it can be safely removed. So it removes P from the
root peer list

C1 continues to run, goes into onClosedConnRemoved, but doesn't find
P in the root peer list, and logs an error.

Since this can happen and does not actually signify an error, we do not
need to log anything in this scenario.

Run Details

3294 of 3890 relevant lines covered (84.68%)

2142.46 hits per line

uber / tchannel-go / 1489 / 2
85%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1489.2

uber / tchannel-go / 1489 / 2 85% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1489.2

uber / tchannel-go / 1489 / 2
85%
dev: 88%

README BADGES
x