1489
85%
dev: 88%

Ran 04 Apr 2016 07:14PM UTC

Jobs 4

Files 40

Run time 1min

Badge

Embed ▾

pending completion

Build # 1489

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Remove error log if onClosedConnRemoved does not find peer

If some peer P has multiple connections C1 and C2, and both close
at the same time, then we have the following sequence of events.
Each connection is running on a separate goroutine.

C1 calls connectionCloseStateChange, removes itself from the connections
list, and is scheduled out before onClosedConnRemoved

C2 calls connectionCloseStateChange, removes itself from the list
and runs onClosedConnRemoved, which will see that there's no connection
for this peer, and it can be safely removed. So it removes P from the
root peer list

C1 continues to run, goes into onClosedConnRemoved, but doesn't find
P in the root peer list, and logs an error.

Since this can happen and does not actually signify an error, we do not
need to log anything in this scenario.

Run Details

3324 of 3905 relevant lines covered (85.12%)

8596.11 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1489.1	04 Apr 2016 07:14PM UTC	40	84.76	Travis Job 1489.1
2	1489.2	04 Apr 2016 07:15PM UTC	40	84.68	Travis Job 1489.2
3	1489.3	04 Apr 2016 07:15PM UTC	40	84.58	Travis Job 1489.3
4	1489.4	04 Apr 2016 07:16PM UTC	40	84.49	Travis Job 1489.4

Source Files on build 1489

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1489
85%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1489

uber / tchannel-go / 1489 85% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1489

uber / tchannel-go / 1489
85%
dev: 88%

README BADGES
x