2
63%
master: 63%

Ran 16 Oct 2023 05:16PM UTC

Files 79

Run time 2s

Badge

Embed ▾

Committed 16 Oct 2023 05:10PM UTC coverage: 58.951% (+0.003%) from 58.948%

Job # 4569427119702016.2

Build Type

push

CirrusCI

Committed by

SomberNight

Commit Message

lnaddr: don't call validate_features in parser

- see comment in lnaddr.py
- Previously we used feature bit 50/51 for trampoline.
  The spec subsequently defined fbit 50/51 as option_zeroconf, which
  requires fbit 46/47 (option_scid_alias) to also be set.
  We moved the non-standard trampoline fbit to a different int.
  However, old wallets might have old invoices saved that set fbit 50/51
  for trampoline, and those would not have the dependent bit set.
  Invoices are parsed at wallet-open, so if the parser ran these checks,
  those wallets could not be opened.
- note: we could potentially also run lnaddr.validate_and_compare_features
  when saving new invoices into the wallet but this is not done here

Run Details

18677 of 31682 relevant lines covered (58.95%)

0.59 hits per line

spesmilo / electrum / 4569427119702016 / 2
63%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4569427119702016.2

spesmilo / electrum / 4569427119702016 / 2 63% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4569427119702016.2

spesmilo / electrum / 4569427119702016 / 2
63%
master: 63%

README BADGES
x