4569427119702016
63%

Ran 16 Oct 2023 05:15PM UTC

Jobs 5

Files 79

Run time 4s

Badge

Embed ▾

Committed 16 Oct 2023 05:10PM UTC coverage: 59.106% (+0.004%) from 59.102%

Build # 4569427119702016

Build Type

push

CirrusCI

Committed by

SomberNight

Commit Message

lnaddr: don't call validate_features in parser

- see comment in lnaddr.py
- Previously we used feature bit 50/51 for trampoline.
  The spec subsequently defined fbit 50/51 as option_zeroconf, which
  requires fbit 46/47 (option_scid_alias) to also be set.
  We moved the non-standard trampoline fbit to a different int.
  However, old wallets might have old invoices saved that set fbit 50/51
  for trampoline, and those would not have the dependent bit set.
  Invoices are parsed at wallet-open, so if the parser ran these checks,
  those wallets could not be opened.
- note: we could potentially also run lnaddr.validate_and_compare_features
  when saving new invoices into the wallet but this is not done here

Run Details

18746 of 31716 relevant lines covered (59.11%)

2.95 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4569427119702016.1	16 Oct 2023 05:15PM UTC	58.99
2	4569427119702016.2	16 Oct 2023 05:16PM UTC	58.95
3	4569427119702016.3	16 Oct 2023 05:16PM UTC	58.95
4	4569427119702016.4	16 Oct 2023 05:16PM UTC	58.96
5	4569427119702016.5	16 Oct 2023 05:24PM UTC	59.01

Source Files on build 4569427119702016

Detailed source file information is not available for this build.

spesmilo / electrum / 4569427119702016
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4569427119702016

spesmilo / electrum / 4569427119702016 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4569427119702016

spesmilo / electrum / 4569427119702016
63%

README BADGES
x