1
76%
main: 76%

Ran 20 Sep 2023 03:32PM UTC

Files 47

Run time 1s

Badge

Embed ▾

Committed 20 Sep 2023 03:24PM UTC coverage: 86.251% (+0.04%) from 86.212%

Job # 6250756795.1

Build Type

push

github

Committed by

web-flow

Commit Message

Fix a possible bug setting finalizers (#2515)

The code that was adding the finalizer
was not really writing it
if the finalizer was the single change
in the reconciliation loop.
As soon as one of the following reconciliation loops
is touching also something else, the finalizer is really set.

So this is basically not affecting real
world executions but it could potentially
hit unit tests if we verify after a single reconciliation loop.

Only a safer fake client like the
controller-runtime v0.16.2 one is showing this.

Let's also remove obsolete code to remove an old finalizer name
since we can safely assume that upgrades to the latest N
released had enough time to amend it.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Run Details

5213 of 6044 relevant lines covered (86.25%)

0.96 hits per line

kubevirt / hyperconverged-cluster-operator / 6250756795 / 1
76%
main: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6250756795.1

kubevirt / hyperconverged-cluster-operator / 6250756795 / 1 76% main: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6250756795.1

kubevirt / hyperconverged-cluster-operator / 6250756795 / 1
76%
main: 76%

README BADGES
x