kubevirt / hyperconverged-cluster-operator / 6250756795

76%

push

github

Fix a possible bug setting finalizers (#2515)

The code that was adding the finalizer
was not really writing it
if the finalizer was the single change
in the reconciliation loop.
As soon as one of the following reconciliation loops
is touching also something else, the finalizer is really set.

So this is basically not affecting real
world executions but it could potentially
hit unit tests if we verify after a single reconciliation loop.

Only a safer fake client like the
controller-runtime v0.16.2 one is showing this.

Let's also remove obsolete code to remove an old finalizer name
since we can safely assume that upgrades to the latest N
released had enough time to amend it.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

1 of 1 new or added line in 1 file covered. (100.0%)

5213 of 6044 relevant lines covered (86.25%)

0.96 hits per line