• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 5558353971 / 1 – cypress
69%
main: 69%

Build:
DEFAULT BRANCH: main
Ran 14 Jul 2023 09:23PM UTC
Files 359
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Jul 2023 09:11PM UTC coverage: 26.423% (+0.001%) from 26.422%
cypress – 5558353971.1

push

github

web-flow
Fix paragraph / line # alignment issue (#608)

## Summary:
Switch from `className` to `id` in css selectors for passage wrappers in an effort to gain higher priority than article paragraph styles.

Change `line-height` on passage `em` elements to 0 since the italicized characters have a subtly different size. See second video for demo of how this resolves the problem.

https://github.com/Khan/perseus/assets/23404711/ae4902b7-128c-45ad-b2f6-56195852b50f

https://github.com/Khan/perseus/assets/23404711/7de0aaeb-891c-4a03-a97a-fa9f147d4892

Issue: LC-698

## Test plan:
- Test in webapp with npm

Author: nedredmond

Reviewers: github-actions[bot], jeremywiebe, nedredmond, handeyeco

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ gerald, ✅ Cypress Coverage (ubuntu-latest, 16.x)

Pull Request URL: https://github.com/Khan/perseus/pull/608

1926 of 9589 branches covered (20.09%)

Branch coverage included in aggregate %.

5521 of 18595 relevant lines covered (29.69%)

937.39 hits per line

Source Files on job cypress - 5558353971.1
  • Tree
  • List 0
  • Changed 16
  • Source Changed 0
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 5558353971
  • a022ff6c on github
  • Prev Job for on main (#5546603673.1)
  • Next Job for on main (#5577999404.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc