Khan / perseus / 5558353971

69%

push

github

Fix paragraph / line # alignment issue (#608)

## Summary:
Switch from `className` to `id` in css selectors for passage wrappers in an effort to gain higher priority than article paragraph styles.

Change `line-height` on passage `em` elements to 0 since the italicized characters have a subtly different size. See second video for demo of how this resolves the problem.

https://github.com/Khan/perseus/assets/23404711/ae4902b7-128c-45ad-b2f6-56195852b50f

https://github.com/Khan/perseus/assets/23404711/7de0aaeb-891c-4a03-a97a-fa9f147d4892

Issue: LC-698

## Test plan:
- Test in webapp with npm

Author: nedredmond

Reviewers: github-actions[bot], jeremywiebe, nedredmond, handeyeco

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ gerald, ✅ Cypress Coverage (ubuntu-latest, 16.x)

Pull Request URL: https://github.com/Khan/perseus/pull/608

7560 of 16353 branches covered (46.23%)

Branch coverage included in aggregate %.

69763 of 95671 relevant lines covered (72.92%)

719.39 hits per line