Instagram
/
IGListKit
/
5489555151
/
1
99%
master: 100%
master: 100%
|
Ran
|
Files
52
|
Run time
0s
|
Badge
Embed ▾
README BADGES
|
coverage: 99.831% (-0.07%) from 99.903%
push
github
facebook-github-botfix crash when calling reloadObjects during an update Summary: Follow up to D47263265 ## What's happening We're calling `listAdapter.reloadObjects(...)` in the middle of the IGListKit's internal data update, so it's using the new section index path, instead of the old one. So we're going from a list of 2, insert at 0, and try to reload index 1, then we crash (it'll try to update index 2, which doesn't exist in the old array) ## Fix Just like for `[IGListAdapter performBatchAnimated:updates:completion:]`, lets use the old index. To get this working, lets ask the updater if we're in an update, rather than `IGListAdapter` try to keep track of it. Sorry the diff is a bit long, but in case this feels reasonable to pick, I might Differential Revision: D47281472 fbshipit-source-id: 193153cfc
4136 of 4143 relevant lines covered (99.83%)
737.6 hits per line
