13
97%
master: 97%

Ran 04 Jul 2023 04:46PM UTC

Files 65

Run time 1s

Badge

Embed ▾

Committed 04 Jul 2023 04:45PM UTC coverage: 48.524%. Remained the same

Job # 5456930725.13

Build Type

push

github

Committed by

web-flow

Commit Message

Fix unknown validator exception when using requires/optional with Entity (#2338)

* Fix crash when using requires/optional with Entity

when that entity specifies keywords that grape interprets as custom validators, ie: is_array, param_type, etc.

This PR changes it so that it skips looking for a custom validator for those special documentation keywords.

This allows you to do something like:

```rb
desc 'Create some entity',
     entity: SomeEntity,
     params: SomeEntity.documentation
params do
  requires :none,
           except: %i[field1 field2],
           using:
             SomeEntity.documentation
end
post do
 ...
end
```

and SomeEntity can specify documentation like:

```rb
      class SomeEntity < Grape::Entity
        expose :id, documentation: { type: Integer, format: 'int64', desc: 'ID' }
        expose :name, documentation: { type: String, desc: 'Name', require: true, param_type: 'body' }
        expose :array_field,
               documentation: {
                 type: String,
                 desc: 'Array Field',
                 require: true,
                 param_type: 'bold'
               }
      end
```

and it won't crash on startup and give you correct documentation and param validation to boot.

Open questions:
1. Is this an exhaustive list of keywords?
2. Is there a better way to maintain/get the list of keywords?
3. Is there a better approach altogeher?

* Cleanup code and add to existing tests that fail without these changes.

* Update after merge with master

* PR feedback

Run Details

559 of 1152 relevant lines covered (48.52%)

0.49 hits per line

ruby-grape / grape / 5456930725 / 13
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job run-3.2-rack_2_0 - 5456930725.13

ruby-grape / grape / 5456930725 / 13 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job run-3.2-rack_2_0 - 5456930725.13

ruby-grape / grape / 5456930725 / 13
97%
master: 97%

README BADGES
x