1
82%
master: 82%

Ran 05 Feb 2016 08:28AM UTC

Files 67

Run time 3s

Badge

Embed ▾

Committed 05 Feb 2016 08:26AM UTC coverage: 81.752% (+0.09%) from 81.665%

Job # 126.1

Build Type

push

travis-ci

Committed by Commit bot

Commit Message

Add support for uint8, uint16 and uint32 in luci/gae

This has come up for like 3 models in DM so far, and I'm tired of having this
be a stupid "gotcha!". I was working around it with some PropertyConverter, but
with this change it will just be obvious what the heck is going on.

They all map to positive int64 values (which should make indexes obvious), and
they include out-of-bounds checks on deserialization.

I excluded uint64, since there's no way to properly encode it in the native
datastore representation which still makes any sense for indexes.

I also added some (apparently?) missing documentation in PLS which explicitly
lays out what field types are allowed in a pls-managed struct.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=550684

Review URL: https://codereview.chromium.org/1667403003

Run Details

6178 of 7557 relevant lines covered (81.75%)

998.61 hits per line

luci / gae / 126 / 1
82%
master: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 126.1

luci / gae / 126 / 1 82% master: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 126.1

luci / gae / 126 / 1
82%
master: 82%

README BADGES
x