5
94%
master: 94%

Ran 18 Jan 2016 04:49AM UTC

Files 42

Run time 1s

Badge

Embed ▾

Committed 18 Jan 2016 03:27AM UTC coverage: 82.228% (+0.05%) from 82.175%

Job # USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true

Build Type

push

travis-ci

Committed by

homu

Commit Message

Auto merge of #310 - micbou:cs-completer, r=Valloric

[READY] Prevent simultaneous starts of OmniSharp server

Currently, C# completer starts a new server on the `FileReadyToParse` event if no port is defined or the running server does not respond. This can lead to situations where multiple servers with same port and solution are started until one of them become ready. See PR #284 and Valloric/YouCompleteMe#1913.

This is fixed by using `ServerIsActive` instead of `ServerIsRunning` to start the server in `OnFileReadyToParse`. We then check `ServerIsRunning` for an early return.

`ServerIsActive` is updated to check the handle (instead of the port) and to poll the process. We cannot only rely on the port because it can be defined while the process is down: server crashed during start up or its process was directly terminated by the user.

`ServerIsRunning` and `ServerIsReady` are also changed. We return early in both methods by checking `ServerIsAlive` first and we restrict exceptions catching.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/310)
<!-- Reviewable:end -->

Run Details

2554 of 3106 relevant lines covered (82.23%)

0.82 hits per line

Valloric / ycmd / 1172 / 5
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1172.5 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true)

Valloric / ycmd / 1172 / 5 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1172.5 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true)

Valloric / ycmd / 1172 / 5
94%
master: 94%

README BADGES
x