• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Valloric / ycmd / 1172
94%

Build:
DEFAULT BRANCH: master
Ran 18 Jan 2016 04:49AM UTC
Jobs 1
Files 42
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1172

push

travis-ci

homu
Auto merge of #310 - micbou:cs-completer, r=Valloric

[READY] Prevent simultaneous starts of OmniSharp server

Currently, C# completer starts a new server on the `FileReadyToParse` event if no port is defined or the running server does not respond. This can lead to situations where multiple servers with same port and solution are started until one of them become ready. See PR #284 and Valloric/YouCompleteMe#1913.

This is fixed by using `ServerIsActive` instead of `ServerIsRunning` to start the server in `OnFileReadyToParse`. We then check `ServerIsRunning` for an early return.

`ServerIsActive` is updated to check the handle (instead of the port) and to poll the process. We cannot only rely on the port because it can be defined while the process is down: server crashed during start up or its process was directly terminated by the user.

`ServerIsRunning` and `ServerIsReady` are also changed. We return early in both methods by checking `ServerIsAlive` first and we restrict exceptions catching.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/310)
<!-- Reviewable:end -->

2554 of 3106 relevant lines covered (82.23%)

0.82 hits per line

Jobs
ID Job ID Ran Files Coverage
5 1172.5 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 18 Jan 2016 04:49AM UTC 0
82.23
Travis Job 1172.5
Source Files on build 1172
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1172
  • 92bc86e1 on github
  • Prev Build on master (#1170)
  • Next Build on master (#1176)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc