• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bwillis / versioncake / 106 / 3
20%
master: 20%

Build:
DEFAULT BRANCH: master
Ran 16 Jan 2014 08:58AM UTC
Files 29
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Jan 2014 08:57AM UTC coverage: 97.494% (-1.5%) from 99.005%
1.9.3, gemfiles/rails4.0.gemfile

push

travis-ci

bwillis
Fixes #22

A PathResolver method that extracts the handler and format was broken
since the re-arrangement of the extensions. It was no longer properly
extracting the format of the template. The symptom was the layout file
was no longer being looked up properly (#22).

The sequence is as follows:
 - look up the template users/index
 - take the template and extract the handler and format, the format is
seen as null
 - set the template format as the new format to use
 - lookup the layout file with the new format to match the template
 - no layout file is found

The fix is to monkey patch the
`ActionView::PathResolver#extract_handler_and_format` method. It will
now make an additional attempt to lookup the types with another part of
the extension if it exists.

It is not ideal to monkey patch Rails methods, but in this case I think
it is necessary. The `extract_handler_and_format` method uses knowledge
of the constants set about the ‘registered details’ to extract the
extension data and since we’ve modified the registered details, we need
to modify the function as well.

428 of 439 relevant lines covered (97.49%)

6.87 hits per line

Source Files on job 106.3 (1.9.3, gemfiles/rails4.0.gemfile)
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 106
  • Travis Job 106.3
  • d060e1db on github
  • Prev Job for 1.9.3, gemfiles/rails4.0.gemfile on master (#105.3)
  • Next Job for 1.9.3, gemfiles/rails4.0.gemfile on master (#107.3)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc