106
20%

Ran 16 Jan 2014 08:58AM UTC

Jobs 5

Files 29

Run time –

Badge

Embed ▾

pending completion

Build # 106

Build Type

push

travis-ci

Committed by

bwillis

Commit Message

Fixes #22

A PathResolver method that extracts the handler and format was broken
since the re-arrangement of the extensions. It was no longer properly
extracting the format of the template. The symptom was the layout file
was no longer being looked up properly (#22).

The sequence is as follows:
 - look up the template users/index
 - take the template and extract the handler and format, the format is
seen as null
 - set the template format as the new format to use
 - lookup the layout file with the new format to match the template
 - no layout file is found

The fix is to monkey patch the
`ActionView::PathResolver#extract_handler_and_format` method. It will
now make an additional attempt to lookup the types with another part of
the extension if it exists.

It is not ideal to monkey patch Rails methods, but in this case I think
it is necessary. The `extract_handler_and_format` method uses knowledge
of the constants set about the ‘registered details’ to extract the
extension data and since we’ve modified the registered details, we need
to modify the function as well.

Run Details

433 of 439 relevant lines covered (98.63%)

33.19 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	106.1 (1.9.2, gemfiles/rails3.2.gemfile)	16 Jan 2014 08:58AM UTC	97.04	Travis Job 106.1
2	106.2 (1.9.3, gemfiles/rails3.2.gemfile)	16 Jan 2014 08:58AM UTC	97.04	Travis Job 106.2
3	106.3 (1.9.3, gemfiles/rails4.0.gemfile)	16 Jan 2014 08:58AM UTC	97.49	Travis Job 106.3
4	106.4 (ruby-head, gemfiles/rails3.2.gemfile)	16 Jan 2014 08:59AM UTC	97.04	Travis Job 106.4
5	106.5 (ruby-head, gemfiles/rails4.0.gemfile)	16 Jan 2014 08:59AM UTC	97.49	Travis Job 106.5

Source Files on build 106

Detailed source file information is not available for this build.

bwillis / versioncake / 106
20%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 106

bwillis / versioncake / 106 20%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 106

bwillis / versioncake / 106
20%

README BADGES
x