zalando-incubator / kube-ingress-aws-controller

71%

master: 72%

LAST BUILD ON BRANCH refs/tags/v0.17.7

branch: refs/tags/v0.17.7

CHANGE BRANCH

x

Reset

• refs/tags/v0.17.7
• add-tag-filter-to-cert-provider
• add-token-refresh
• add-worker-type
• adds-ingress-type-metrics
• aws/fix-list-cert-error-handling
• aws/fix-test-name
• aws/log-multiple-az-subnets
• aws/sort-subnets
• bugfix/detached-tg-when-cf-stack-rollingback
• build/fix-multiacrh-version
• certificate-mock
• cf-update-schema
• change-settings-owned-lb
• check-lb-state-before-ingress-update
• check-stack-errors
• clean-warnings
• count-changes
• delay-ingress-status-update
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/setup-go-5
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/docker/build-push-action-6
• dependabot/github_actions/docker/login-action-3
• dependabot/github_actions/docker/metadata-action-5
• dependabot/github_actions/docker/setup-buildx-action-3
• dependabot/github_actions/docker/setup-qemu-action-3
• dependabot/go_modules/all-go-mod-patch-and-minor-2e95f9df4a
• dependabot/go_modules/all-go-mod-patch-and-minor-75bece2739
• dependabot/go_modules/all-go-mod-patch-and-minor-9e9a10268a
• dependabot/go_modules/all-go-mod-patch-and-minor-a3d96f8245
• dependabot/go_modules/all-go-mod-patch-and-minor-aa2579bb3a
• dependabot/go_modules/all-go-mod-patch-and-minor-af8c894126
• dependabot/go_modules/all-go-mod-patch-and-minor-dc9f81fc5d
• dependabot/go_modules/all-go-mod-patch-and-minor-ee8a91ac27
• dependabot/go_modules/all-go-mod-patch-and-minor-f270798a91
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.50.29
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.51.11
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.51.32
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.53.14
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.54.11
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.55.5
• dependabot/go_modules/github.com/containerd/containerd-1.7.27
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.0.5
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.1
• dependabot/go_modules/github.com/redis/go-redis/v9-9.7.3
• dependabot/go_modules/github.com/zalando/skipper-0.21.102
• dependabot/go_modules/github.com/zalando/skipper-0.21.135
• dependabot/go_modules/github.com/zalando/skipper-0.21.166
• dependabot/go_modules/github.com/zalando/skipper-0.21.36
• dependabot/go_modules/github.com/zalando/skipper-0.21.78
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• deploy/use-static-base-image
• deps-1.27
• doc-non-ec2
• doc/acm-tagging
• doc/ghcr-registy
• doc/zone-aware-traffic
• enable-dualstack-nlb
• external-dns-integration
• fabric-external-dns
• feature/nlb-zone-affinity-via-r53
• fix-error-checking
• fix-file-path
• fix-goldenfiles-tests
• fix-image-build
• fix-polling-rate
• fix-prod-build
• fix-release-notes
• fix-staticcheck
• fix/disable-nlb-cross-zone-balancing
• fix/use-ingress-v1-default
• gh-packages
• github/group-update
• go-restful-2.16.0
• golangci-lint-update
• images/use-stricter-base-image
• ingress-upgrade-v1
• internal/aws/cloudformation/fix-go-vet
• internal/aws/cloudformation/update-schema
• kube-1.29
• legacy-target-access-mode
• logs-ingress-type
• master
• migrate/aws-sdk-go-v2
• more-tests
• more-tests-v2
• move-more-mocks-to-fake
• move-nlb-subnet
• multi-arch-image
• refs/tags/v0.15.10
• refs/tags/v0.15.11
• refs/tags/v0.15.12
• refs/tags/v0.15.13
• refs/tags/v0.15.14
• refs/tags/v0.15.15
• refs/tags/v0.15.16
• refs/tags/v0.15.17
• refs/tags/v0.15.18
• refs/tags/v0.15.19
• refs/tags/v0.15.20
• refs/tags/v0.15.21
• refs/tags/v0.15.22
• refs/tags/v0.15.23
• refs/tags/v0.15.24
• refs/tags/v0.15.25
• refs/tags/v0.15.26
• refs/tags/v0.15.27
• refs/tags/v0.15.28
• refs/tags/v0.15.29
• refs/tags/v0.15.30
• refs/tags/v0.15.31
• refs/tags/v0.15.32
• refs/tags/v0.15.33
• refs/tags/v0.15.34
• refs/tags/v0.15.35
• refs/tags/v0.15.6
• refs/tags/v0.15.7
• refs/tags/v0.15.8
• refs/tags/v0.15.9
• refs/tags/v0.16.0
• refs/tags/v0.17.0
• refs/tags/v0.17.1
• refs/tags/v0.17.2
• refs/tags/v0.17.3
• refs/tags/v0.17.6
• refs/tags/v0.18.0
• refs/tags/v0.18.1
• refs/tags/v0.18.10
• refs/tags/v0.18.12
• refs/tags/v0.18.2
• refs/tags/v0.18.3
• refs/tags/v0.18.4
• refs/tags/v0.18.5
• refs/tags/v0.18.6
• refs/tags/v0.18.7
• refs/tags/v0.18.8
• refs/tags/v0.18.9
• remove-fabric-support
• remove-logs
• require-labels
• store-arns-as-tags
• support-unwrap-verb
• switch/base-image
• switch/base-image-to-0cve
• test/cf-stack-in-rollback
• test/eks-karp-ipv6-target-groups
• tests/flags
• tests/update-stack
• update-deps
• update-deps-1.30
• update-deps-2022-04
• update-deps-2023-03-01
• update-deps-2023-09
• update-deps-2024-04-17
• update-deps-25-09-19
• update-deps-k8s-1.31
• update-go1.25
• update-ingress-only-if-elb-is-ready-to-serve
• update/dependencies
• update/dependency-skipper
• update/pass-context-to-apis
• vendor-in-cloudformation
• worker/log-ingress-name

Build # 16068739792

Build Type

push

github

Committed by web-flow

Commit Message

fix: update ingress status only if the load balancer is active (#748)

As per the existing behavior, once the stack update completes, the
ingress controller immediately updates the status of all ingresses and
routegroups to reference the new load balancer. This update may
sometimes happens before the new load balancer has marked its targets
(for example skipper-ingress) as healthy, leading clients being routed to a load
balancer that is not ready to serve traffic yet.

To improve this behavior we retrieve the ELBs via AWS API and build the
models including the ELB states of the corresponding ELBs. Then before
updating the ingresses/routegroups (updateIngress func) we check whether
the ELB is in active state, if not we skip updating the
ingresses/routegroups status with the ELB hostname.

---------

Signed-off-by: Thilina Madumal <thilina.madumal@zalando.de>

Run Details

109 of 124 new or added lines in 6 files covered. (87.9%)

2 existing lines in 1 file now uncovered.

2752 of 3882 relevant lines covered (70.89%)

10.6 hits per line