zalando-incubator / kube-ingress-aws-controller
72%
master: 72%

LAST BUILD BRANCH: refs/tags/v0.21.0
DEFAULT BRANCH: master
Repo Added
Files 27
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refs/tags/v0.21.0
branch: SELECT
CHANGE BRANCH
x

coverage: 71.762% (+0.2%) from 71.519%
25554052666

push

github

web-flow 
Add opt-out support for load-balancer-type: none (#795)

- [x] In `newIngress` (`kubernetes/adapter.go`): return `nil, nil` when
`loadBalancerType == loadBalancerTypeNone`, before the NLB/WAF check and
map lookup
- [x] In `ListIngress` and `ListRoutegroups`: guard append with `ing !=
nil`; log the exclusion at Info level
- [x] Add unit tests: Ingress and RouteGroup with
`zalando.org/aws-load-balancer-type: none` are excluded from
`ListResources`
- [x] Add `TestNewIngressFromRouteGroup` test case: RouteGroup with
`zalando.org/aws-load-balancer-type: none` returns `nil, nil` from
`newIngressFromRouteGroup` (parallel to the `TestNewIngressFromKube`
case)
- [x] Add fixture entry with `zalando.org/aws-load-balancer-type: none`
and class `skipper` to `testdata/fixture01.json` and
`testdata/fixture01_rg.json`; assert count in `TestListIngress` stays at
1
- [x] Add fixture entry with `zalando.org/aws-load-balancer-type: none`
and without class to testdata/fixture01.json and
testdata/fixture01_rg.json; assert count in TestListIngress stays at 1
- [x] Update README
- [x] Bump minor version

Update:
- [x] Move the check for opt out out of the ingress business object
- [x] Add helper function `hasLoadBalancerTypeNone`
- [x] Remove `TestNewIngressFromRouteGroup` and the scenario in
`TestNewIngressFromKube` - these were added because the previous logic
existed within the ingress object, now we check for the load balancer
type `none` early

ref:
https://github.com/zalando-incubator/kube-ingress-aws-controller/issues/794

---------

Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>

27 of 27 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

2948 of 4108 relevant lines covered (71.76%)

12.79 hits per line

Relevant lines Covered
4108 RELEVANT LINES 2948 COVERED LINES
12.79 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25554052666 refs/tags/v0.21.0 Add opt-out support for load-balancer-type: none (#795) - [x] In `newIngress` (`kubernetes/adapter.go`): return `nil, nil` when `loadBalancerType == loadBalancerTypeNone`, before the NLB/WAF check and map lookup - [x] In `ListIngress` and `ListRo... push web-flow github
71.76
25553781072 master Add opt-out support for load-balancer-type: none (#795) - [x] In `newIngress` (`kubernetes/adapter.go`): return `nil, nil` when `loadBalancerType == loadBalancerTypeNone`, before the NLB/WAF check and map lookup - [x] In `ListIngress` and `ListRo... push web-flow github
71.76
25543411228 add/opt-out-annotation - fix lint error Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com> Pull #795 greeshma1196 github
71.76
25504077323 rm-registry.opensource.zalan.do Remove references to registry.opensource.zalan.do Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de> Pull #796 mikkeloscar github
71.52
25425932266 add/opt-out-annotation - update readme - bump minor version - add more testdata fixtures Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com> Pull #795 greeshma1196 github
71.67
25379855525 add/opt-out-annotation - add opt-out support for `zalando.org/aws-load-balancer-type: none` - add relevant tests Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com> Pull #795 greeshma1196 github
71.67
25211667963 dependabot/go_modules/all-go-mod-patch-and-minor-a1bb12a4ee build(deps): bump the all-go-mod-patch-and-minor group with 12 updates Bumps the all-go-mod-patch-and-minor group with 12 updates: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2)... Pull #793 web-flow github
71.52
25211668949 dependabot/go_modules/all-go-mod-patch-and-minor-a1bb12a4ee build(deps): bump the all-go-mod-patch-and-minor group with 12 updates Bumps the all-go-mod-patch-and-minor group with 12 updates: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2)... Pull #793 web-flow github
71.52
25166386571 refs/tags/v0.20.7 fix: go version set to Go 1.26.2 (#776) fix: go version set to Go 1.26.2 --------- Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de> push web-flow github
71.52
25056514847 refs/tags/v0.20.6 fix: go version set to Go 1.26.2 (#776) fix: go version set to Go 1.26.2 --------- Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de> push web-flow github
71.52
See All Builds (2444)