zalando-incubator / kube-ingress-aws-controller
71%
master: 72%

LAST BUILD BRANCH: enable-dualstack-nlb
DEFAULT BRANCH: master
Repo Added
Files 27
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH cf-update-schema
branch: cf-update-schema
CHANGE BRANCH
x

coverage: 70.891%. Remained the same
16443052181

Pull #754

github

AlexanderYastrebov 
internal/aws/cloudformation: update schema scraper

Update schema scraper:

* use build tag to avoid running during normal build
* use specific CloudFormation schema
* include only types used by the controller
* omit writing schema.json
* remove build id, commit and timestamp from schema.go
* remove examples and custom resources tests that use other types not used by the controller

Then regenerate schema.go without updating CloudFormation schema version
to only include in schema.go types used by the controller.

Here is the minimal diff excluding removed lines to demonstrate that used types did not change:

```console
$ git diff --minimal master -- internal/aws/cloudformation/schema.go | grep -Ev '^-'
```
```diff
diff --git a/internal/aws/cloudformation/schema.go b/internal/aws/cloudformation/schema.go
index a6274a3..94751b6 100644
+++ b/internal/aws/cloudformation/schema.go
@@ -1,17 +1,14 @@
 package cloudformation

 // RESOURCE SPECIFICATION VERSION: 24.0.0
+import "time"
+import "encoding/json"
+import _ "gopkg.in/go-playground/validator.v9" // Used for struct level validation tags

 const ResourceSpecificationVersion = "24.0.0"

+var _ = time.Now
+
 // CustomResourceProvider allows extend the NewResourceByType factory method
 // with their own resource types.
 type CustomResourceProvider func(customResourceType string) ResourceProperties
@@ -36,12885 +33,6 @@ func RegisterCustomResourceProvider(provider CustomResourceProvider) {
 //                 |_|
 //

 // CloudWatchAlarmDimension represents the AWS::CloudWatch::Alarm.Dimension CloudFormation property type
 // See http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cw-dimension.html
 type CloudWatchAlarmDimension struct {
@@ -13045,13330 +163,6 @@ func (l *CloudWatchAlarmMetricStatList) UnmarshalJSON(buf []byte) error {
        return err
 }

 // ElasticLoadBalancingV2ListenerAction represents the AWS::ElasticLoadBalancingV2::Listener.Action CloudFormation property t... (continued)
Pull Request #754: internal/aws/cloudformation: update schema scraper

2752 of 3882 relevant lines covered (70.89%)

10.6 hits per line

Relevant lines Covered
3882 RELEVANT LINES 2752 COVERED LINES
10.6 HITS PER LINE
Source Files on cf-update-schema

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16443052181 cf-update-schema internal/aws/cloudformation: update schema scraper Update schema scraper: * use build tag to avoid running during normal build * use specific CloudFormation schema * include only types used by the controller * omit writing schema.json * remove b... Pull #754 AlexanderYastrebov github
70.89
16443005183 cf-update-schema internal/aws/cloudformation: update schema scraper Update schema scraper: * use build tag to avoid running during normal build * use specific CloudFormation schema * include only types used by the controller * omit writing schema.json * remove b... push AlexanderYastrebov github
70.89
16442924232 cf-update-schema internal/aws/cloudformation: update schema scraper Update schema scraper: * use build tag to avoid running during normal build * use specific CloudFormation schema * include only types used by the controller * omit writing schema.json * remove b... push AlexanderYastrebov github
70.89
16442911942 cf-update-schema internal/aws/cloudformation: update schema scraper Update schema scraper: * use build tag to avoid running during normal build * use specific CloudFormation schema * include only types used by the controller * omit writing schema.json * remove b... push AlexanderYastrebov github
70.89
See All Builds (2322)