zalando-incubator / kube-ingress-aws-controller

73%

master: 73%

LAST BUILD ON BRANCH aws/fix-list-cert-error-handling

branch: aws/fix-list-cert-error-handling

CHANGE BRANCH

x

Reset

• aws/fix-list-cert-error-handling
• master
• store-arns-as-tags
• fix/disable-nlb-cross-zone-balancing
• tests/flags
• tests/update-stack
• ingress-upgrade-v1
• bugfix/detached-tg-when-cf-stack-rollingback
• test/cf-stack-in-rollback
• require-labels
• more-tests-v2
• move-nlb-subnet
• worker/log-ingress-name
• aws/log-multiple-az-subnets
• add-tag-filter-to-cert-provider
• more-tests
• fix-goldenfiles-tests
• aws/fix-test-name
• go-restful-2.16.0
• update-deps-2023-09
• move-more-mocks-to-fake
• support-unwrap-verb
• certificate-mock
• fix-image-build
• clean-warnings
• update-deps-2023-03-01
• doc-non-ec2
• doc/ghcr-registy
• gh-packages
• legacy-target-access-mode
• fix-file-path
• add-token-refresh
• update/dependency-skipper
• change-settings-owned-lb
• golangci-lint-update
• remove-fabric-support
• update/dependencies
• fix-prod-build
• multi-arch-image
• fix/use-ingress-v1-default
• fix-polling-rate
• fabric-external-dns
• external-dns-integration
• count-changes
• check-stack-errors
• remove-logs
• adds-ingress-type-metrics
• logs-ingress-type
• fix-error-checking
• update-deps-2022-04
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.50.29
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.0
• refs/tags/v0.15.6
• refs/tags/v0.15.7
• doc/acm-tagging
• refs/tags/v0.15.8
• update-deps
• refs/tags/v0.15.9
• deps-1.27
• refs/tags/v0.15.10
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.51.11
• dependabot/go_modules/github.com/zalando/skipper-0.21.36
• refs/tags/v0.15.11
• refs/tags/v0.15.12
• update-deps-2024-04-17
• refs/tags/v0.15.13
• refs/tags/v0.15.14
• kube-1.29
• feature/nlb-zone-affinity-via-r53
• doc/zone-aware-traffic
• refs/tags/v0.15.15
• dependabot/go_modules/github.com/zalando/skipper-0.21.78
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.51.32
• switch/base-image-to-0cve
• switch/base-image
• images/use-stricter-base-image
• refs/tags/v0.15.16
• dependabot/go_modules/github.com/prometheus/client_golang-1.19.1
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.53.14
• dependabot/go_modules/github.com/zalando/skipper-0.21.102
• deploy/use-static-base-image
• refs/tags/v0.15.17
• refs/tags/v0.15.18
• refs/tags/v0.15.19
• build/fix-multiacrh-version
• refs/tags/v0.15.20
• update-deps-1.30
• refs/tags/v0.15.21
• dependabot/go_modules/github.com/zalando/skipper-0.21.135
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.54.11
• refs/tags/v0.15.22
• refs/tags/v0.15.23
• dependabot/go_modules/github.com/zalando/skipper-0.21.166
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.55.5
• refs/tags/v0.15.24
• refs/tags/v0.15.25
• github/group-update
• dependabot/github_actions/actions/setup-go-5
• dependabot/github_actions/docker/login-action-3
• dependabot/github_actions/docker/metadata-action-5
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/docker/setup-qemu-action-3
• dependabot/go_modules/all-go-mod-patch-and-minor-2e95f9df4a
• refs/tags/v0.15.26
• update-deps-k8s-1.31
• refs/tags/v0.15.27
• dependabot/go_modules/all-go-mod-patch-and-minor-9e9a10268a
• fix-staticcheck
• refs/tags/v0.15.28
• refs/tags/v0.15.29
• refs/tags/v0.15.30
• refs/tags/v0.15.31
• dependabot/github_actions/docker/setup-buildx-action-3
• dependabot/github_actions/docker/build-push-action-6
• dependabot/go_modules/all-go-mod-patch-and-minor-75bece2739

Build # 11348612721

Build Type

Pull #725

github

Committed by AlexanderYastrebov

Commit Message

aws: fail on ListCertificatesPages error

`getACMCertificateSummaries` did not check `ListCertificatesPages` error
and returned empty `CertificateSummary` slice and no error
via `filterCertificatesByTag` if `filterTag` is configured.

Empty `CertificateSummary` results in empty `existingStackCertificateARNs`
for each `loadBalancer` model which triggered stack update:
```
level=info msg="Updating \"internet-facing\" stack for 0 certificates / 0 ingresses"
```
and then stack deletion on the next cycle:
```
level=info msg="Deleted orphaned stack \"kube-ingress-aws-controller-aws-XXX\""
```
due to empty certificate tags after previous update.

Follow up on #658

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

Pull Request Pull Request #725: aws: fail on ListCertificatesPages error

Run Details

21 of 21 new or added lines in 2 files covered. (100.0%)

3067 of 4202 relevant lines covered (72.99%)

11.26 hits per line