xenserver-next / xen-api

79%

feature/py3: 78%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• CI-merge-master-coveralls-simplify-future-merges
• Fix-Site.BaseURL-links-use-relative-internal-links-instead
• Hugo-docs-updates-to-Relearn-6.4.0-an-newer-Hugo
• XenAPIPlugin.py-ditch-superflous-raise-SystemExit
• backup-sr-metadata-2to3-and-warningfixes
• cleanup-docs-fix-a-few-typos
• codecov-fallback
• coveralls-finish-parallel-upload
• delete-obsolete-ocaml/idl/ocaml_backend/python
• docs-add-NUMA-infos
• docs-add-possibility-to-preview-in-clone
• docs-fix-a-few-spelling-omissions
• docs-fix-spelling-ommit-to-omit
• docs-invert-images-in-dark-modes
• docs-support-hugo-previews-of-PRs-on-gh-pages
• docs-update-README-and-hugo-relearn-to-5.23
• docs-update-VM.start-xenguest-calls
• docs-update-to-upstream-Hugo-Relearn-7.3.2
• extauth-ad-fix-byte-logging-found-by-mypy
• extauth-hook-AD-cleanup-per-method-pylint-comments
• extauth-hook-AD-delete-obsolete-PBIS
• extauth-hook-AD-fix-missing-abc-metaclass
• extauth-hook-AD-modernize-import-and-import-mocking
• extauth-hook-ad-fix-checker-warnings
• feature/py3
• fix-pytype-remove-unused-get_words-and-test-it
• fix-spelling-and-typos-in-python3
• fix-xenopsd-passing-two-args-to-append
• master
• merge-master-into-py3-for-coveralls
• mv-and-fix-test_mail_alarm-py3
• private/ashwin/CP-49906
• private/linl/dev
• py3-cleanup-unused-imports
• py3-covert-tests-to-use-unittest.mock
• py3-improve-mypy-configuration-usability
• py3-merge-master-fix-opam-install
• py3-merge-master-to-fix-opam
• py3-scripts/generate-iscsi-iqn
• py3_pytest_rrdd_api_data_update
• py3_test_rrdd_api_data_update
• pytest-update-paths-and-pyright
• remove-legacy-SMAPIv3-API
• storage-api-cleanup-string-checks
• storage-api-cleanup-string-checks-with-coverage
• storage-api-cleanup-string-checks-with-test-coverage
• storage-api-cover-datapath_dispatcher
• storage-api-test-datapath_dispatcher
• storage-api-unfold-very-long-line
• storage-api-use-not-is_long
• storage-api-use-str-not-in-args
• test_rrdd_api_data_update
• update-endcover-to-v2
• update-endcover-to-v2.1
• when-only-Hugo-docs-change-full-Xapi-CI-is-not-needed
• xe-reset-networking-covert-tabs-to-spaces
• xenopsd-remove-orphaned-qemu-vif-script

Build # 14722509390

Build Type

push

github

Committed by web-flow

Commit Message

message_forwarding: Change call_slave_... functions to reduce repetition (#6321)

These functions were calling remote functions with rpc and session_id as
unnamed parameters. Because the remote functions always gave these two
parameters named, it required closures throughout the file to fix this
inconsistency.

This creates a lot of unnecessary code. Change the situation by making
call_slave_... functions to call the functions using named parameters,
and group the local and remote functions whenever a chain
to_call_slave_... is initiated so it's easy to verify that the calls are
correct.

Most of the callers use the same name for both local and remote
functions, but there are some interesting cases that can be easily seen
now: pool_eject always uses the same remote function for 3 different
types of members in the pool, previously 3 different closures were
created and the code had to be careful with names to not confuse the
ejected host from the ejectors.

When starting a vm, the local function is start_on, while the remote
function is start, the formers needs an additional host parameter, when
compared to the latter.

A lot of functions in message_forwarding look very regular, this may
lead to a chance to further reduce glue code, or even generate the code?

Run Details

3512 of 4473 relevant lines covered (78.52%)

0.79 hits per line