wol-soft / php-json-schema-model-generator

98%

master: 99%

LAST BUILD ON BRANCH filter-composition-ordering

branch: filter-composition-ordering

CHANGE BRANCH

x

Reset

• filter-composition-ordering
• 0.1.0
• 0.10.0
• 0.10.1
• 0.11.0
• 0.11.1
• 0.12.0
• 0.13.0
• 0.14.0
• 0.14.1
• 0.15.0
• 0.15.1
• 0.16.0
• 0.17.0
• 0.18.0
• 0.19.0
• 0.2.0
• 0.20.0
• 0.21.0
• 0.21.1
• 0.21.2
• 0.21.3
• 0.21.4
• 0.21.5
• 0.21.6
• 0.21.7
• 0.21.8
• 0.22.0
• 0.22.1
• 0.23.0
• 0.23.1
• 0.23.2
• 0.23.3
• 0.23.4
• 0.23.5
• 0.24.0
• 0.24.1
• 0.24.2
• 0.25.0
• 0.25.1
• 0.26.1
• 0.26.2
• 0.3.0
• 0.3.1
• 0.4.0
• 0.5.0
• 0.6.0
• 0.7.0
• 0.8.0
• 0.9.0
• 65-recursive-reference-resolving
• 70-filter-in-composition
• AddOptionToDefaultArraysToEmptyArray
• AdvancedFilter
• BaseProcessor
• BuilderClassPostProcessor
• CompositionValidationOnMutableObjects
• FormatValidation
• JsonSchemaDraftTestSuite
• MoveCI
• NestedObjectException
• OptimizeMergedProperties
• PatternProperties
• PerformanceImprovements
• PostProcessor
• PostProcessorHooks
• ReworkExceptions
• SchemaHooks
• SkipFilterAfterTransformingFilterIfTransformationFails
• ThrowExceptionFromNestedModel
• additionalProperties
• attributes
• booleanSchemas
• chore/phpunit-13-upgrade
• debug
• drafts
• enumPostProcessor
• feat/composition-required-promotion
• fix/issue-101
• fix/issue-110
• fix/issue-129-enum-type-check-validator
• fix/issue-98
• implicitNullableConfiguration
• improveRefResolving
• issue72_nestedComposition
• issue77_dynamicProperty
• issue79_CombinedRefAndObjectDefinition
• jsonSchemaDraft7
• master
• modernizeCode
• optionalConst
• patch-1
• php82tessting
• refImprovements
• renameRawModelDataInput
• supportNumericProperties
• typos
• useInNestedReferences

Build # 26169686326

Build Type

Pull #128

github

Committed by wol-soft

Commit Message

Close filter/composition coverage gaps: remove dead code, add targeted tests

- Remove unreachable !is_array() guards in CompositionBranchClassifier:
  the not branch always receives an array (NotValidatorFactory wraps it),
  and non-array allOf/anyOf/oneOf values crash before the classifier runs.

- Drop redundant testOutputTypeNotExtendedWhenReturnTypeAlreadyInBaseType:
  the applyOutputType early-return path is already exercised by the
  existing testOutputSpaceNotCompositionRunsPostTransform which uses the
  same type:["string","integer"] + stringToInt schema shape.

- Extend testNoExtendedInstanceOfCheckWhenAllObjectBranchesAreNonEmpty
  with an unparseable-string assertion: 'Hello' passes the input-space
  anyOf (via type:string) but fails the dateTime filter, throwing
  InvalidFilterValueException.

- Move testFilterOnObjectTypedPropertyWithNestedSchema to
  FilterTypeCompatibilityTest (no composition in that schema) and add a
  real runtime assertion: array input is instantiated to the inner class
  by ObjectInstantiationDecorator, then the filter converts it to DateTime.

- Add static test cases for root-level then/else constraining a filtered
  subproperty with output-type-space keywords, a filter inside an if
  sub-schema within an allOf branch, and root-level not with an
  input-space keyword on a filtered subproperty.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #128: Filter composition ordering

Coverage Stats

771 of 790 new or added lines in 22 files covered. (97.59%)

5454 of 5538 relevant lines covered (98.48%)

594.2 hits per line