umputun / spot
84%
master: 84%

LAST BUILD BRANCH: fix/executor-correctness
DEFAULT BRANCH: master
Repo Added
Token fKmP3eE00CORXdCzaKDWoCzm5XFlwui2k regen
Build 956 Last
Files 19
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/executor-correctness
branch: fix/executor-correctness
CHANGE BRANCH
x
Sync Branches

coverage: 84.034%. First build
28776180924

Pull #358

github

paskal 
executor: fix context-cancellation leaks, local copy bugs, drop dead options

- sshRun: buffer the done channel so the command goroutine can exit
  after a ctx-cancel return instead of blocking forever (goroutine leak).
- sftpUpload/sftpDownload: build the sftp client over an ssh session we
  hold (newSftpSession), and on ctx-cancel close that session to abort
  the in-flight transfer from outside the sftp mutex, then drain the copy
  goroutine before returning. newSftpSession drains the session stderr
  pipe in a goroutine (RequestSubsystem never starts the copy that
  Session.Stderr would use, so unread stderr would stall the channel).
  The cancel drain is bounded by a grace timeout so an app-level wedge
  cannot hang the deploy; a transport-level wedge is left to a follow-up.
- sftpDownload now downloads into a temp file in the destination dir and
  renames over the destination only on success, so a canceled or failed
  download no longer truncates or destroys an existing local file (newly
  reachable now that a download actually aborts mid-copy).
- Local.Upload: multi-file glob + mkdir creates the destination directory
  itself, and honors context cancellation between files.
- Local.Download: pass the caller context through.
- Connector.String: cap the private-key slice with min().
- Remove dead options never read by any executor: Checksum from
  UpDownOpts and SyncOpts, and Force from SyncOpts, plus the config
  sync 'force' field (undocumented no-op) and its schema entry. Behavior
  change: under strict YAML a playbook that set 'sync: {force: true}'
  will now fail to parse.
Pull Request #358: executor: fix context-cancellation leaks, local copy bugs, drop dead options

87 of 117 new or added lines in 4 files covered. (74.36%)

3279 of 3902 relevant lines covered (84.03%)

59.3 hits per line

Relevant lines Covered
3902 RELEVANT LINES 3279 COVERED LINES
59.3 HITS PER LINE
Source Files on fix/executor-correctness

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28776180924 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
84.03
28776070880 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
84.1
28757660161 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
83.88
28754880190 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
83.78
28750024928 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
84.05
See All Builds (885)