umputun / spot
84%
master: 84%

LAST BUILD BRANCH: refs/tags/v1.19.1
DEFAULT BRANCH: master
Repo Added
Token fKmP3eE00CORXdCzaKDWoCzm5XFlwui2k regen
Build 864 Last
Files 19
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-single-quoted-vars
branch: fix-single-quoted-vars
CHANGE BRANCH
x
Sync Branches

coverage: 84.341% (+0.07%) from 84.267%
15260472739

Pull #287

github

umputun 
Fix preservation of single-quoted environment variables

This change addresses issue #285 where bcrypt passwords and other values
containing dollar signs were being corrupted when passed between commands
via environment variables.

The root cause was that when variables were exported with single quotes
(to prevent shell expansion), this intent was lost when the templater
substituted the values in subsequent commands.

Changes:
- Add exportKeyWithQuote method to detect single-quoted exports
- Mark single-quoted variables with :SQ suffix in setvar output
- Store single-quoted values with __SQ__: prefix internally
- Escape dollar signs during template substitution for SQ-marked values
- Update tests to handle new setvar format
- Add unit tests for templater handling of single-quoted values
- Update documentation to show correct single-quote approach

The fix ensures that when users export variables with single quotes like:
  export BCRYPT_PASSWORD='$2a$14$G.j2F3fm9wluTougUU52sOzePOvvpujjRrCoVp5qWVZ6qRJh58ISC'

The literal value is preserved throughout the variable lifecycle, preventing
shell expansion of special characters.

Also includes minor formatting fix in pkg/executor/remote.go.
Pull Request #287: Fix preservation of single-quoted environment variables

54 of 54 new or added lines in 3 files covered. (100.0%)

2860 of 3391 relevant lines covered (84.34%)

53.78 hits per line

Relevant lines Covered
3391 RELEVANT LINES 2860 COVERED LINES
53.78 HITS PER LINE
Source Files on fix-single-quoted-vars

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
15260472739 fix-single-quoted-vars Fix preservation of single-quoted environment variables This change addresses issue #285 where bcrypt passwords and other values containing dollar signs were being corrupted when passed between commands via environment variables. The root cause ... Pull #287 umputun github
84.34
See All Builds (799)