umputun / spot
84%

DEFAULT BRANCH: master
Repo Added
Token fKmP3eE00CORXdCzaKDWoCzm5XFlwui2k regen
Build 956 Last
Files 19
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 84.034% (-0.1%) from 84.168%
28776367930

push

github

umputun 
executor: fix context-cancellation leaks, local copy bugs, drop dead options

- sshRun: buffer the done channel so the command goroutine can exit
  after a ctx-cancel return instead of blocking forever (goroutine leak).
- sftpUpload/sftpDownload: build the sftp client over an ssh session we
  hold (newSftpSession), and on ctx-cancel close that session to abort
  the in-flight transfer from outside the sftp mutex, then drain the copy
  goroutine before returning. newSftpSession drains the session stderr
  pipe in a goroutine (RequestSubsystem never starts the copy that
  Session.Stderr would use, so unread stderr would stall the channel).
  The cancel drain is bounded by a grace timeout so an app-level wedge
  cannot hang the deploy; a transport-level wedge is left to a follow-up.
- sftpDownload now downloads into a temp file in the destination dir and
  renames over the destination only on success, so a canceled or failed
  download no longer truncates or destroys an existing local file (newly
  reachable now that a download actually aborts mid-copy).
- Local.Upload: multi-file glob + mkdir creates the destination directory
  itself, and honors context cancellation between files.
- Local.Download: pass the caller context through.
- Connector.String: cap the private-key slice with min().
- Remove dead options never read by any executor: Checksum from
  UpDownOpts and SyncOpts, and Force from SyncOpts, plus the config
  sync 'force' field (undocumented no-op) and its schema entry. Behavior
  change: under strict YAML a playbook that set 'sync: {force: true}'
  will now fail to parse.

87 of 117 new or added lines in 4 files covered. (74.36%)

26 existing lines in 2 files now uncovered.

3279 of 3902 relevant lines covered (84.03%)

59.29 hits per line

Relevant lines Covered
3902 RELEVANT LINES 3279 COVERED LINES
59.29 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28776367930 master executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... push umputun github
84.03
28776180924 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
84.03
28776070880 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
84.1
28772153844 feat/task-import refactor(config): simplify import resolution code Pull #359 robertobarreda github
84.36
28757660161 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
83.88
28756797116 master config: fix inline comment stripping and simplified-playbook options - scriptCommand stripped a single-line script from the first '#' anywhere, which mangled '#' inside a token (e.g. ${VAR#prefix}) or inside a quoted string (e.g. "fix #1"). I... push umputun github
84.17
28754959250 fix/defensive-guards guards: decrypt length check, ssh user nil guard, command count across hosts - decrypt now rejects ciphertext shorter than the 24-byte nonce plus 16-byte salt with an error instead of panicking on the slice. - sshUser had an inverted nil guard:... Pull #357 paskal github
84.06
28754880190 fix/executor-correctness executor: fix context-cancellation leaks, local copy bugs, drop dead options - sshRun: buffer the done channel so the command goroutine can exit after a ctx-cancel return instead of blocking forever (goroutine leak). - sftpUpload/sftpDownload: ... Pull #358 paskal github
83.78
28754880978 fix/config-parsing config: fix inline comment stripping and simplified-playbook options - scriptCommand stripped a single-line script from the first '#' anywhere, which mangled '#' inside a token (e.g. ${VAR#prefix}) or inside a quoted string (e.g. "fix #1"). I... Pull #355 paskal github
84.17
28750757113 master docs, schema and build/ci hygiene fixes - README: drop the non-existent --local-shell / SPOT_LOCAL_SHELL flag (local shell is a playbook field only), correct the --temp env var name from SPOT_TEMP_DIR to SPOT_TEMP, and fix the delete example ... push umputun github
83.99
See All Builds (885)