umputun / revdiff
88%
master: 90%

LAST BUILD BRANCH: refs/tags/v1.6.1
DEFAULT BRANCH: master
Repo Added
Token zpy25XdTlXkHx5U3syYGatR9U5X0sk8oe regen
Build 747 Last
Files 71
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/diff-viewport-visual-height-scroll
branch: fix/diff-viewport-visual-height-scroll
CHANGE BRANCH
x
Sync Branches

coverage: 88.374% (+0.01%) from 88.362%
24580605021

Pull #118

github

umputun 
fix(ui): keep wrap and annotation rows visible at viewport bottom

syncViewportToCursor compared only the cursor's top row to the viewport
bottom, so when the cursor sat on the last visible row with a logical line
taller than one visual row, the extra rows (wrap continuations under
--wrap, or multi-line annotation rows injected below the diff line)
rendered past the viewport bottom and were clipped.

Introduce cursorVisualRange/cursorVisualHeight to compute the cursor's
full visual extent via the existing hunkLineHeight / wrappedLineCount /
wrappedAnnotationLineCount helpers. syncViewportToCursor now scrolls
against the cursor's visual bottom, with a min(..., cursorTop) floor so
a logical line taller than the viewport keeps the cursor top anchored.
SetContent runs before SetYOffset so viewport.maxYOffset() reflects
post-mutation content length.

Also add syncViewportToCursor() to the editor-finished save path in
saveComment so a freshly saved multi-row annotation scrolls into view
when the cursor sits near the bottom.

Tests cover wrap-overflow, annotation-overflow, cursor-on-annotation
sub-line overflow, file-annotation overflow, cursor-taller-than-viewport
floor, editor-save line-level sync, and editor-save file-level GotoTop.
Pull Request #118: fix(ui): keep wrap and annotation rows visible at viewport bottom

30 of 32 new or added lines in 2 files covered. (93.75%)

7054 of 7982 relevant lines covered (88.37%)

331.68 hits per line

Relevant lines Covered
7982 RELEVANT LINES 7054 COVERED LINES
331.68 HITS PER LINE
Source Files on fix/diff-viewport-visual-height-scroll

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24580605021 fix/diff-viewport-visual-height-scroll fix(ui): keep wrap and annotation rows visible at viewport bottom syncViewportToCursor compared only the cursor's top row to the viewport bottom, so when the cursor sat on the last visible row with a logical line taller than one visual row, the e... Pull #118 umputun github
88.37
See All Builds (653)

Badge your Repo: revdiff

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh