umputun / revdiff
90%
master: 91%

LAST BUILD BRANCH: feat/herdr-pane-overlay
DEFAULT BRANCH: master
Repo Added
Token zpy25XdTlXkHx5U3syYGatR9U5X0sk8oe regen
Build 967 Last
Files 79
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH clamp-scrollx
branch: clamp-scrollx
CHANGE BRANCH
x
Sync Branches

coverage: 90.152% (+0.04%) from 90.117%
33195480393

Pull #337

github

umputun 
fix(ui): bound horizontal scroll to the widest rendered line

Holding the right arrow scrolled scrollX past the widest line without limit.
Once past every line applyHorizontalScroll takes its plain-cut branch with
both overflow flags false, so every row cuts to nothing and the diff pane
goes blank with no « indicator to explain it — recoverable only by scrolling
all the way back or switching files.

Every nonzero write to scrollX now goes through setScrollX, bounded by the
widest row the pane currently renders, so a runaway offset can no longer cut
the whole document away. This does not promise every viewport shows content
at every legal offset: a wide row further down the file owns the bound, so
short rows on screen can still cut to empty. That per-line behavior lives in
applyHorizontalScroll and is pinned as deliberate by
TestModel_ApplyHorizontalScrollNoLeftIndicatorWhenScrolledPastContent.

The bound reads the rendered document rather than the loaded one: collapsed
mode hides removed lines, so a wide hidden removal must not widen it, and
expanding a hunk reveals those lines again. Delete-only placeholders are
measured from their own synthetic text.

Per-line widths are cached at load, parallel to file.lines, so the bound
costs an integer scan rather than re-measuring strings on every keypress.
The walk uses a moving hunk index rather than hunkStartFor, which rescans
the whole hunk slice per line.

Layout changes that widen the pane lower the bound without a horizontal
keypress of their own. All four — resize, tree hide, line-number and blame
toggles — already render through syncViewportToCursor, so the clamp lives
there; the two collapsed mutations render directly and clamp locally.

Related to #334, which surfaced this while asking for mouse horizontal
scroll. The mouse gesture is a separate question and stays open.
Pull Request #337: fix(ui): bound horizontal scroll to the widest rendered line

66 of 68 new or added lines in 3 files covered. (97.06%)

11608 of 12876 relevant lines covered (90.15%)

3469.07 hits per line

Relevant lines Covered
12876 RELEVANT LINES 11608 COVERED LINES
3469.07 HITS PER LINE
Source Files on clamp-scrollx

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33195480393 clamp-scrollx fix(ui): bound horizontal scroll to the widest rendered line Holding the right arrow scrolled scrollX past the widest line without limit. Once past every line applyHorizontalScroll takes its plain-cut branch with both overflow flags false, so eve... Pull #337 umputun github
90.15
33194744638 clamp-scrollx fix(ui): bound horizontal scroll to the widest rendered line Holding the right arrow scrolled scrollX past the widest line without limit. Once past every line applyHorizontalScroll takes its plain-cut branch with both overflow flags false, so eve... push umputun github
90.15
See All Builds (853)

Badge your Repo: revdiff

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh