stripe / smokescreen

56%

master: 56%

LAST BUILD ON BRANCH harold/decide_interface

branch: harold/decide_interface

CHANGE BRANCH

x

Reset

Sync Branches

• harold/decide_interface
• acl-validate
• allow-different-resolvers
• allow-private-ranges-default-option
• alternative-ip
• anuragm/add-server-ip-headers
• bump-goproxy
• bump-gp-version
• cds/bump-go-version.1
• cds/bump-goproxy
• cds/connection-timing
• cds/fix-ca-tests
• cds/fix-lookup-denials
• cds/fix-shutdown-behavior
• cds/fix-timeout-test
• cds/go-1.15
• cds/ipv4-only-lookups
• cds/log-outbound-host
• cds/per-conn-duration-metric
• cds/smokescreen-metrics
• cgnat-ssrf
• client-timeout
• cmoresco/bump
• cmoresco/bump-statsd
• cmoresco/config
• cmoresco/conn-success
• cmoresco/connstats
• cmoresco/contributors
• cmoresco/docs
• cmoresco/docs-ip
• cmoresco/export
• cmoresco/hooks
• cmoresco/interface
• cmoresco/metrics-package
• cmoresco/response
• cmoresco/server
• connect-local
• conntrack-project-tag
• cschen-conntrack-project-tag
• denylist-log
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.1
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• dependabot/go_modules/gopkg.in/yaml.v2-2.2.8
• dos-timeout
• example-com
• feature/AddPrometheusMetrics
• fishdev/add-cn-metric-tags
• flag
• gauthamw/https-proxy
• gauthamw/proxy-hooks
• gauthamw/vendor-goproxy-update
• harold/goveralls-build
• harold/mitm_support
• harold/mitm_support_2
• harold/update-build
• idle-conn-fix
• jjiang-coverage-badge
• jjiang-goveralls
• jjiang-test
• jjiang/fix-hostname
• jjiang/fix-logging-addrs
• jjiang/more-square-brackets
• jjiang/normalize-hosts-in-acl-validation
• jjiang/tag-based-metrics
• kevinv/fix-test-map-keys
• kevinv/tag-metrics-requested-host
• lewandowski/connect-normalization
• lewandowski/github-actions
• lewandowski/idna
• lewandowski/normalization
• lewandowski/normalize-pkg
• lewandowski/underscores
• lewandowski/v6
• lewandowski/version
• manishsb/support-custom-middleware-for-smokescreen-requests
• master
• mattm-15
• mattm-lint
• metric-sanitize
• mitm-acl
• non-prefix-wildcard
• param-allow-callbacks-for-request-verification
• private-ip
• pspieker-add-proxy-acl-support
• pspieker-fix-proxy-host-url-parsing
• pspieker-gp-scatch
• pspieker-testing-gp-changes
• pspieker-tmp
• ransford-dns-query-time-metric
• ransford-mod-update
• ransford-readme-updates
• ransford/bump-ci
• ransford/connect-error-metrics
• ransford/globs
• ransford/metrics
• rate-limit-dos
• refs/tags/v0.0.3
• refs/tags/v0.0.4
• request-timeout
• revert-262-dos-timeout
• revert-269-client-timeout
• rishikej-missing-log-fields
• rishikej-timeout-log
• rwg/log-tcp-tuples.0
• rwg/star.0
• saurabhbhatia/add-reject-handler
• saurabhbhatia/alert-autofix-1
• saurabhbhatia/alert-autofix-2
• saurabhbhatia/default_bypass_fix
• saurabhbhatia/enhc-error-messages
• saurabhbhatia/smokescreen-ctx-changes
• saurabhbhatia/update-goproxy
• saurabhbhatia/update-goproxy-again
• sergeyrud-make-hostMatchesGlob-exportable
• sergeyrud-move-custom-request-handler-after-the-main-check
• shubh/fix-http-role-logging
• shubh/glob-with-hostnames
• sohamsen/fix-flaky-example.com
• sohamsen/ipv6-embedding
• sohamsen/metric-fix-high-cardinality
• sohamsen/race-fix
• stable-log-field-names
• subtree-merge
• test-branch
• tunnel-limiter
• update-docs
• upgrade-golang
• validate
• xieyuxi-configurable-proxy-addrs

Build # 24177641349

Build Type

Pull #286

github

Committed by harold-s

Commit Message

smokescreen: remove TestHostSquareBrackets

Go 1.21 tightened URL validation in both the HTTP client (url.Parse) and
the HTTP server (request-line parsing), causing both layers to reject
hostnames containing square brackets before the request reaches
smokescreen's handler. The test can no longer exercise smokescreen's own
host-validation logic for these inputs and is removed.

Committed-By-Agent: claude

Pull Request Pull Request #286: acl: pass *http.Request through Decide via DecideArgs

Coverage Stats

14 of 15 new or added lines in 2 files covered. (93.33%)

9 existing lines in 1 file now uncovered.

1812 of 3224 relevant lines covered (56.2%)

46.51 hits per line