stripe / smokescreen
56%

DEFAULT BRANCH: master
Repo Added
Token p3r3qYDPNxVPUXqvYLjFKjFquJXwV6ERu regen
Build 681 Last
Files 25
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x
Sync Branches

coverage: 56.203% (-0.2%) from 56.415%
24180064184

push

github

web-flow 
acl: pass *http.Request through Decide via DecideArgs (#286)

* acl: replace Decide(service, host, proxy) with Decide(DecideArgs)

Replace the three positional string arguments on the Decider interface with
a DecideArgs struct. This keeps the interface stable as new fields are
added — the immediate motivation is passing *http.Request so custom Decider
implementations (e.g. request-aware authorization layers) can inspect request
headers without requiring a separate interface method.

ACL.Decide itself does not inspect Req; the field is documented as existing
solely for custom implementations. Tests are updated to use the new struct
form and two previously missing proxy-host cases are added (allowed proxy +
disallowed target, wildcard proxy glob), along with a test asserting that
ACL.Decide produces identical results regardless of the Req value.

Committed-By-Agent: claude

* smokescreen: remove TestHostSquareBrackets

Go 1.21 tightened URL validation in both the HTTP client (url.Parse) and
the HTTP server (request-line parsing), causing both layers to reject
hostnames containing square brackets before the request reaches
smokescreen's handler. The test can no longer exercise smokescreen's own
host-validation logic for these inputs and is removed.

Committed-By-Agent: claude

---------

Co-authored-by: Harold Simpson <harold@stripe.com>

14 of 15 new or added lines in 2 files covered. (93.33%)

9 existing lines in 1 file now uncovered.

1812 of 3224 relevant lines covered (56.2%)

46.51 hits per line

Relevant lines Covered
3224 RELEVANT LINES 1812 COVERED LINES
46.51 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24180064184 master acl: pass *http.Request through Decide via DecideArgs (#286) * acl: replace Decide(service, host, proxy) with Decide(DecideArgs) Replace the three positional string arguments on the Decider interface with a DecideArgs struct. This keeps the inte... push web-flow github
56.2
22099438009 master Implement tunnel limiting in smokescreen (#284) * Implement tunnel limiting * Change denyError to tunnelLimitError * Fix build error push web-flow github
56.42
20851823156 master Prevent smokescreen upstream connections to its local IPs (#282) * Prevent smokescreen upstream connections to itself * Add tests * Add test to validate no error push web-flow github
55.99
20331928078 master Enable ACL checking for MITM requests (#279) * Add ACL check for MITM * Remove debug logs * Fix test * Rebuild MITM request context by copying only role from existing context * Add check for sctx.Decision Co-authored-by: harold-stripe <49162... push web-flow github
55.52
19896156662 master Enable rate and concurrency limiting (#280) * Add rate and concurrency limiter * Add unit test * Fix review changes * Add burst rate validation * Declare all default values in config file * Update Readme * Fix import error * Move concurren... push web-flow github
55.53
19637750763 master Fix idle connection per host config (#278) push web-flow github
55.78
19060121852 master Add support for IPv6 embedding schemes in address classification (#277) This update introduces handling for various IPv6 embedding schemes, including NAT64, 6to4, and Teredo, in the address classification logic. New tests have been added to ensur... push web-flow github
55.86
18914777943 master Add client request timeout values (#276) push web-flow github
55.52
18864021082 master Add hooks to configure upstream proxy (#275) push web-flow github
55.58
18551629439 master Revert "Add client request body and header timeout as 10s" (#273) push web-flow github
55.48
See All Builds (561)