stacklok / toolhive-studio
71%
main: 71%

LAST BUILD BRANCH: v0.36.3-rc.1
DEFAULT BRANCH: main
Repo Added
Files 522
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/startup-no-flash
branch: fix/startup-no-flash
CHANGE BRANCH
x

coverage: 70.544% (+0.04%) from 70.508%
26943648296

Pull #2304

github

peppescg 
fix(startup): address Copilot review feedback

- `toolhive-manager.ts`: capture `toolhiveSocketPath` into a local const
  before the readiness probe runs (it can be cleared by `child.on('exit')`
  on fast-fail). Unref the `setTimeout` timers in `probeSocket` and the
  `waitForSocketReady` polling loop so they don't keep the Electron main
  event loop alive during shutdown. Export both functions so they can be
  tested independently.

- `toolhive-manager.test.ts`: add 6 tests covering the readiness probe —
  connect/error/timeout for `probeSocket`, success/early-exit/eventual-
  success for `waitForSocketReady`. Mock `net.connect` with a default
  ENOENT-on-next-tick stub so existing `startToolhive` tests (which now
  trigger a detached readiness probe inside the Sentry.withScope mock)
  don't fail with `undefined.once` access.

- `renderer/index.html`: add `role="status"`, `aria-live="polite"`,
  `aria-busy="true"` to the splash container so screen readers announce
  the loading state. Mark the decorative spinner `aria-hidden="true"`.
  Respect `prefers-reduced-motion: reduce` by disabling the spin
  animation for users with vestibular sensitivities.
Pull Request #2304: fix(startup): eliminate cold-start window flash by awaiting socket readiness

5216 of 8014 branches covered (65.09%)

29 of 35 new or added lines in 2 files covered. (82.86%)

7738 of 10969 relevant lines covered (70.54%)

115.29 hits per line

Relevant lines Covered
10969 RELEVANT LINES 7738 COVERED LINES
115.29 HITS PER LINE
Source Files on fix/startup-no-flash

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26943648296 fix/startup-no-flash fix(startup): address Copilot review feedback - `toolhive-manager.ts`: capture `toolhiveSocketPath` into a local const before the readiness probe runs (it can be cleared by `child.on('exit')` on fast-fail). Unref the `setTimeout` timers in `p... Pull #2304 peppescg github
70.54
26939594552 fix/startup-no-flash fix(startup): eliminate cold-start window flash by awaiting socket readiness Three coupled changes that together remove the dark-window flash users see between launching the app and the renderer becoming interactive. 1. `startToolhive()` now act... Pull #2304 peppescg github
70.53
See All Builds (2606)