samvera / browse-everything
100%
master: 99%

LAST BUILD BRANCH: issues-372-jrgriffiniii-rails6.1
DEFAULT BRANCH: master
Repo Added
Files 19
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH remove_explicit_sass_rails_dependency
branch: remove_explicit_sass_rails_dependency
CHANGE BRANCH
x

978

push

travis-ci

jrochkind 
remove explicit sass-rails dependency

A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency.

While current Rails releases generate with sass-rails dependency, sass-rails is sunsetted/deprecated, due to the underlying pure-ruby ruby-sass gem being deprecated, and instructs "consider switching to the sassc gem"  https://github.com/sass/ruby-sass .

Rails 6.0 will perhaps depend on the sassc-rails gem instead, or perhaps the sass-rails gem itself will be changed to depend on sassc instead of sass-ruby. I am not sure if it is yet determined/done. https://github.com/rails/rails/issues/3289

But apps now may wish to switch to sassc-rails, especially if it's a new app. While sassc-rails _ought_ to be a drop-in replacement, bugs can happen, and the timeline of switching (or refraining from switching) should be up to a dependent app.  However, if an app depends on both sass-rails and sassc-rails, problems can occur. https://github.com/sass/sassc-rails/issues/6

So, removing the sass-rails as an explicit dependency from browse-everything will allow dependent apps to choose sass-rails or sassc-rails themselves, switching on their own timeline, without the browse-everything dependency interfering. This change is unlikely to pose any backwards compatibility problems, as dependent apps should have sass-rails in their Gemfile already, as it is generated by Rails. In the unlikely event some dependent app did not have sass-rails independently declared as a dependency, however, they would have to add it."

708 of 711 relevant lines covered (99.58%)

471.34 hits per line

Relevant lines Covered
711 RELEVANT LINES 708 COVERED LINES
471.34 HITS PER LINE
Source Files on remove_explicit_sass_rails_dependency
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
978 remove_explicit_sass_rails_dependency remove explicit sass-rails dependency A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency. While current Rails releases generate with... push jrochkind travis-ci pending completion  
977 remove_explicit_sass_rails_dependency remove explicit sass-rails dependency A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency. While current Rails releases generate with... Pull #250 web-flow travis-ci pending completion  
975 remove_explicit_sass_rails_dependency remove explicit sass-rails dependency A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency. While current Rails releases generate with... push jrochkind travis-ci pending completion  
See All Builds (681)