samvera / browse-everything / 978
100%
master: 99%

LAST BUILD BRANCH: issues-372-jrgriffiniii-rails6.1
DEFAULT BRANCH: master
Ran
Jobs 12
Files 20
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
978

push

travis-ci

jrochkind 
remove explicit sass-rails dependency

A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency.

While current Rails releases generate with sass-rails dependency, sass-rails is sunsetted/deprecated, due to the underlying pure-ruby ruby-sass gem being deprecated, and instructs "consider switching to the sassc gem"  https://github.com/sass/ruby-sass .

Rails 6.0 will perhaps depend on the sassc-rails gem instead, or perhaps the sass-rails gem itself will be changed to depend on sassc instead of sass-ruby. I am not sure if it is yet determined/done. https://github.com/rails/rails/issues/3289

But apps now may wish to switch to sassc-rails, especially if it's a new app. While sassc-rails _ought_ to be a drop-in replacement, bugs can happen, and the timeline of switching (or refraining from switching) should be up to a dependent app.  However, if an app depends on both sass-rails and sassc-rails, problems can occur. https://github.com/sass/sassc-rails/issues/6

So, removing the sass-rails as an explicit dependency from browse-everything will allow dependent apps to choose sass-rails or sassc-rails themselves, switching on their own timeline, without the browse-everything dependency interfering. This change is unlikely to pose any backwards compatibility problems, as dependent apps should have sass-rails in their Gemfile already, as it is generated by Rails. In the unlikely event some dependent app did not have sass-rails independently declared as a dependency, however, they would have to add it."

708 of 711 relevant lines covered (99.58%)

471.34 hits per line

Jobs
ID Job ID Ran Files Coverage
1 978.1 (2.5.1, RAILS_VERSION=5.2.0) 0
99.58
 Travis Job 978.1
2 978.2 (2.4.4, RAILS_VERSION=5.2.0) 0
99.58
 Travis Job 978.2
3 978.3 (2.3.7, RAILS_VERSION=5.2.0) 0
99.58
 Travis Job 978.3
4 978.4 (2.5.1, RAILS_VERSION=5.1.6) 0
99.58
 Travis Job 978.4
5 978.5 (2.4.4, RAILS_VERSION=5.1.6) 0
99.58
 Travis Job 978.5
6 978.6 (2.3.7, RAILS_VERSION=5.1.6) 0
99.58
 Travis Job 978.6
7 978.7 (2.5.1, RAILS_VERSION=5.0.7) 0
99.58
 Travis Job 978.7
8 978.8 (2.4.4, RAILS_VERSION=5.0.7) 0
99.58
 Travis Job 978.8
9 978.9 (2.3.7, RAILS_VERSION=5.0.7) 0
99.58
 Travis Job 978.9
10 978.10 (2.5.1, RAILS_VERSION=4.2.10) 0
99.58
 Travis Job 978.10
11 978.11 (2.4.4, RAILS_VERSION=4.2.10) 0
99.58
 Travis Job 978.11
12 978.12 (2.3.7, RAILS_VERSION=4.2.10) 0
99.58
 Travis Job 978.12
Source Files on build 978