samvera / browse-everything

99%

master: 99%

LAST BUILD ON BRANCH no_symbols_in_example_yaml

branch: no_symbols_in_example_yaml

CHANGE BRANCH

x

Reset

• no_symbols_in_example_yaml
• 247-config-error
• aws-s3
• bootstrap4-again
• boxv2
• bs3_only
• decaf
• doc-templates
• driver/google
• es5_only
• figgy-issues-3201-jrgriffiniii
• figgy-issues-3273-jrgriffiniii
• figgy-issues-3273-jrgriffiniii-rebase
• figgy-issues-3273-jrgriffiniii-rebase2
• figgy-issues-3273-jrgriffiniii-unsquashed
• figgy-issues-3522-jrgriffiniii
• file-size
• fix-circleci-bundler
• fix-generator
• fix-license
• fix-symbol-config
• github
• issues-271-jrgriffiniii-readme-circleci
• issues-279-jrgriffiniii-test-ruby-rails-latest
• issues-291-jrgriffiniii-google-auth-0.9
• issues-310-jrgriffiniii-sprockets-4
• issues-372-jrgriffiniii-rails6.1
• issues-rails6.1-jrgriffiniii
• jul19-ruby-versions
• karma_doc
• long-filenames
• master
• next/rails-api/jrgriffiniii
• next/rails-api/jrgriffiniii-enginecart-bugfixes
• next/rails-api/jrgriffiniii-file-system
• next/rails-api/jrgriffiniii-integration-specs
• next/rails-api/jrgriffiniii-webpacker
• no-more-parties
• no_coffee
• pare-down-travis
• rails51
• remove-s3-dotdot
• remove_explicit_sass_rails_dependency
• remove_font_awesome
• remove_skydrive
• rubocop-fixes
• s3_configurable_expires
• s3_includes_filename
• samvera-readme
• selenum-fix-test
• skip-nil-sized-files
• stream_body
• test-ruby-rails
• test_matrix
• v0.14.0
• v0.14.1
• v0.14.2
• v0.15.0
• v0.15.1
• v0.16.0
• v0.16.1
• v1.0.0
• v1.0.0.rc2
• v1.0.0rc1
• v1.0.1

Build # 848

Build Type

push

travis-ci

Committed by jrochkind

Commit Message

example providers yaml should not use symbols

Under at least some versions of ruby you will get a:

    /Users/jrochkind/.rubies/ruby-2.3.1/lib/ruby/2.3.0/psych/class_loader.rb:97:in `find': Tried to load unspecified class: Symbol (Psych::DisallowedClass)
   ....
    from /Users/jrochkind/.rubies/ruby-2.3.1/lib/ruby/2.3.0/psych.rb:302:in `safe_load'
    from /Users/jrochkind/code/browse-everything/lib/browse_everything.rb:56:in `configure'

from having a raw symbol in Yaml. Commit a9ec7df0cfb10ea removed symbols
from yaml _keys_ in browse_everything_providers.yml.example, perhaps for this reason (or not, there are no relevant comments on commit), but retained the :signed_url as a value. Which still causes that safe Yaml error, safe yaml does not like symbols.

Changing it to a string seems to work fine, without causing that problem.

Run Details

555 of 559 relevant lines covered (99.28%)

99.98 hits per line