rohanpm / kobo

50%

master: 49%

LAST BUILD ON BRANCH refactored-gssapi

branch: refactored-gssapi

CHANGE BRANCH

x

Reset

• refactored-gssapi
• 0.8.0
• fix-middleware-compat
• fork-task-log-exceptions
• logging-thread-py3
• logging-thread-recover
• middleware-TypeError
• release-via-travis
• remove-auto-logout
• retire-content-delivery-release-bot
• test-improvements

Build # 22

Build Type

push

travis-ci

Committed by rohanpm

Commit Message

Refactor gssapi login method to reuse krb5login endpoint

For gssapi auth, there is no need to add a new XML-RPC method
on the hub and step through the gssapi process on both client
and server sides ourselves.  Let's just authenticate with the
existing krb5login endpoint instead.

The advantages of doing it this way include:

- As no hub changes are needed at all, it already works on any
  hub deployed today, i.e. clients can upgrade to Python3/gssapi
  without blocking on the hub upgrading first.

- Avoids reimplementing client side of gssapi process, instead
  reusing it from requests_gssapi.
  (some code is still needed for configuration however.)

- Avoids reimplementing server side of gssapi process, instead
  reusing it from httpd or whichever server is placed in front
  of the hub.

- When login_krbv is dropped, it will mean there's only one place
  where kerberos auth needs to be configured on the hub, rather than
  two which currently need to be kept in sync with each other
  (hub settings and httpd settings).

- Since the auth is no longer tunneled inside of XML-RPC, authentication
  requests from kobo clients will now appear in httpd logs.

Run Details

3030 of 6085 relevant lines covered (49.79%)

0.5 hits per line